[google_maps_flutter] Marker clustering support #4319

jokerttu · 2023-06-27T07:03:36Z

Adds the initial support for the marker clustering for Android, iOS and Web platforms.
Clustering is implemented using native google maps utils libraries for Android, iOS and Web.

This PR is created from previous PR: flutter/plugins#6752

Resolves flutter/flutter#26863

Android:

iOS:

Web:

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hixie · 2023-08-22T22:52:35Z

@jokerttu Is this still something you are interested in working on? How can we help you?

thedalelakes · 2023-10-05T15:41:28Z

@jokerttu is this still something you're working on?

jokerttu · 2023-10-13T13:39:36Z

@jokerttu is this still something you're working on?

Yes, I am scheduled to work on this issue next week and will update the PR accordingly in the near future. The recent architectural changes in the google_maps_flutter_web implementation have affected the integration tests, which I am addressing. Additionally, some new methods introduced in this PR will likely require updates to the native unit tests.

wangela · 2023-10-30T15:57:25Z

@stuartmorgan this is ready for review. We inspected the logs for the failing web platform tests and it seems to be reporting based on Android?

jokerttu · 2023-10-31T08:28:34Z

Note: that the original PR was reviewed at plugins repository at flutter/plugins#6752
Implementation parts have been mainly same, but small fixes and changes has been done to fix conflicts.
Web tests are rewritten because of changes on the web implementation (web plugin was endorsed).
iOS Google Maps Utils library version is now pinned to 4.1.0 as newer versions do not support iOS platform versions 11 and 12

stuartmorgan · 2023-11-17T12:19:22Z

@stuartmorgan this is ready for review. We inspected the logs for the failing web platform tests and it seems to be reporting based on Android?

This is because there is a weird circular dependency in the tests where google_maps_flutter_web's example depends on google_maps, which then is depending on a non-overridden version of google_maps_flutter_android so things no longer match. Adding a dependency override for _android in google_maps_flutter_web/example/pubspec.yaml should allow the tests to run.

stuartmorgan

Thanks for your patience on this; I've finished reviewing the platform interface, and since the overall structure was already reviewed in the previous PR you are good to split that out into the first prequel PR. I've left some comments that you can either address here before splitting, or just address in the new PR.

I should have the rest of the re-review done later today but I wanted to get this part out first so you could work on that in parallel.

...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart

packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/cluster.dart

...oogle_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/cluster_manager.dart

packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/cluster.dart

...maps_flutter_platform_interface/lib/src/platform_interface/google_maps_flutter_platform.dart

...oogle_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/cluster_manager.dart

stuartmorgan · 2023-11-17T13:12:20Z

@ditman Looks like the original never got your review for web; if you could take a look here when you get a chance that would be great.

packages/google_maps_flutter/google_maps_flutter_web/README.md

packages/google_maps_flutter/google_maps_flutter/pubspec.yaml

packages/google_maps_flutter/google_maps_flutter/example/lib/clustering.dart

packages/google_maps_flutter/google_maps_flutter_ios/lib/src/google_maps_flutter_ios.dart

packages/google_maps_flutter/google_maps_flutter_ios/lib/src/utils/cluster_manager.dart

packages/google_maps_flutter/google_maps_flutter_web/example/web/index.html

packages/google_maps_flutter/google_maps_flutter_web/lib/src/marker_clustering.dart

apackin · 2024-01-16T18:00:35Z

Any progress updates on when we can expect this to come out?

hellohuanlin · 2024-01-17T21:55:47Z

@jokerttu is this ready for another review?

jokerttu · 2024-01-18T18:01:21Z

@hellohuanlin

@jokerttu is this ready for another review?

Not yet, most of the issues @stuartmorgan pointed out are fixed, but there are still few that are not yet done.
Also, before this can be finalized, we need also some resolution to this question waiting review from @ditman: (#4319 (comment))

…ion (#6186) This PR introduces support for marker clustering for iOS platform An example usabe is available in the example application at ./packages/google_maps_flutter/google_maps_flutter_ios/example/ios12 on the page `Manage clustering` This is prequel PR for: #4319 and sequel PR for: #6158 Containing only changes to `google_maps_flutter_ios` package. Follow up PR will hold the app-facing plugin implementation. Linked issue: flutter/flutter#26863

stuartmorgan

LGTM!

…ckages#4319)

flutter/packages@551bde5...5cc0a01 2024-08-07 stuartmorgan@google.com [ci] Update repository for the release of Flutter 3.24 (flutter/packages#7331) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from b0850be to 80c2e84 (1397 revisions) (flutter/packages#7322) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.5 to 4.3.6 (flutter/packages#7330) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.7 to 1.13.12 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7189) 2024-08-07 joonas.kerttula@codemate.com [google_maps_flutter] Marker clustering support (flutter/packages#4319) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.15 to 3.26.0 (flutter/packages#7329) 2024-08-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 1dd7141 to 0a7f8af (23 revisions) (flutter/packages#7328) 2024-08-06 magder@google.com [image_picker_ios] Update image picker UI test query for iOS 18 (flutter/packages#7325) 2024-08-06 joonas.kerttula@codemate.com [google_maps_flutter] Add marker clustering support - iOS implementation (flutter/packages#6186) 2024-08-06 8014077+Frank3K@users.noreply.github.com [url_launcher] launchUrl always returns true for valid schemes on the web. (flutter/packages#7229) 2024-08-06 rexios@rexios.dev [google_maps_flutter] Add heatmap support (flutter/packages#3257) 2024-08-06 stuartmorgan@google.com [local_auth] Endorse macOS (flutter/packages#7274) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…er#153040) flutter/packages@551bde5...5cc0a01 2024-08-07 stuartmorgan@google.com [ci] Update repository for the release of Flutter 3.24 (flutter/packages#7331) 2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from b0850be to 80c2e84 (1397 revisions) (flutter/packages#7322) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.5 to 4.3.6 (flutter/packages#7330) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.7 to 1.13.12 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7189) 2024-08-07 joonas.kerttula@codemate.com [google_maps_flutter] Marker clustering support (flutter/packages#4319) 2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.15 to 3.26.0 (flutter/packages#7329) 2024-08-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 1dd7141 to 0a7f8af (23 revisions) (flutter/packages#7328) 2024-08-06 magder@google.com [image_picker_ios] Update image picker UI test query for iOS 18 (flutter/packages#7325) 2024-08-06 joonas.kerttula@codemate.com [google_maps_flutter] Add marker clustering support - iOS implementation (flutter/packages#6186) 2024-08-06 8014077+Frank3K@users.noreply.github.com [url_launcher] launchUrl always returns true for valid schemes on the web. (flutter/packages#7229) 2024-08-06 rexios@rexios.dev [google_maps_flutter] Add heatmap support (flutter/packages#3257) 2024-08-06 stuartmorgan@google.com [local_auth] Endorse macOS (flutter/packages#7274) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

stuartmorgan · 2024-08-08T11:53:24Z

Temporarily locking, as this is attracting a lot of off-topic comments. Discussion on a PR should be about the code in the PR, not things like follow-up requests.

github-actions bot added p: google_maps_flutter platform-android platform-ios platform-web labels Jun 27, 2023

jokerttu force-pushed the google_maps_flutter_cluster_support branch 2 times, most recently from b805eab to 499b82b Compare June 30, 2023 13:26

Zazo032 mentioned this pull request Jul 25, 2023

[google_maps_flutter] Support marker clustering flutter/flutter#26863

Closed

jokerttu force-pushed the google_maps_flutter_cluster_support branch 5 times, most recently from b44d05a to e052a4c Compare October 26, 2023 12:33

jokerttu marked this pull request as ready for review October 27, 2023 14:52

jokerttu requested review from cyanglaz, reidbaker, ditman and stuartmorgan as code owners October 27, 2023 14:52

stuartmorgan reviewed Nov 17, 2023

View reviewed changes

stuartmorgan requested changes Nov 17, 2023

View reviewed changes

jokerttu requested a review from hellohuanlin as a code owner December 20, 2023 09:31

Rexios80 mentioned this pull request Aug 6, 2024

[google_maps_flutter] Plans for adapting Maps SDK Utility Library for google_maps_flutter flutter/flutter#50636

Open

jokerttu force-pushed the google_maps_flutter_cluster_support branch from 850bf1e to bf56884 Compare August 6, 2024 19:58

jokerttu force-pushed the google_maps_flutter_cluster_support branch from bf56884 to 0d9224c Compare August 6, 2024 20:06

jokerttu marked this pull request as ready for review August 6, 2024 20:47

This comment was marked as resolved.

Sign in to view

jokerttu force-pushed the google_maps_flutter_cluster_support branch 2 times, most recently from d5d476a to 19f7ea4 Compare August 7, 2024 06:32

jokerttu added 3 commits August 7, 2024 12:10

[google_maps_flutter] Add clustering support

c85da79

[google_maps_flutter] change cdn for markerclustering js library

9e696e1

[google_maps_flutter] add tests for clustermanager updates.

7632a2e

jokerttu force-pushed the google_maps_flutter_cluster_support branch from 19f7ea4 to 7632a2e Compare August 7, 2024 09:10

stuartmorgan approved these changes Aug 7, 2024

View reviewed changes

jokerttu added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 7, 2024

auto-submit bot merged commit 244cd4c into flutter:main Aug 7, 2024
76 checks passed

engine-flutter-autoroll mentioned this pull request Aug 7, 2024

Roll Packages from 551bde53f6ea to f330ca3c2fa3 (11 revisions) flutter/flutter#153025

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2024

244cd4cf9 [google_maps_flutter] Marker clustering support (flutter/pa…

54ac93e

…ckages#4319)

engine-flutter-autoroll mentioned this pull request Aug 7, 2024

Roll Packages from 551bde53f6ea to 5cc0a0160194 (12 revisions) flutter/flutter#153040

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2024

244cd4cf9 [google_maps_flutter] Marker clustering support (flutter/pa…

6333680

…ckages#4319)

This comment was marked as off-topic.

Sign in to view

flutter locked as off-topic and limited conversation to collaborators Aug 8, 2024

jokerttu deleted the google_maps_flutter_cluster_support branch September 9, 2024 10:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[google_maps_flutter] Marker clustering support #4319

[google_maps_flutter] Marker clustering support #4319

jokerttu commented Jun 27, 2023 •

edited

Loading

Hixie commented Aug 22, 2023

thedalelakes commented Oct 5, 2023

jokerttu commented Oct 13, 2023

wangela commented Oct 30, 2023

jokerttu commented Oct 31, 2023 •

edited

Loading

stuartmorgan commented Nov 17, 2023

stuartmorgan left a comment

stuartmorgan commented Nov 17, 2023

apackin commented Jan 16, 2024

hellohuanlin commented Jan 17, 2024

jokerttu commented Jan 18, 2024 •

edited

Loading

This comment was marked as resolved.

stuartmorgan left a comment

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

stuartmorgan commented Aug 8, 2024

[google_maps_flutter] Marker clustering support #4319

[google_maps_flutter] Marker clustering support #4319

Conversation

jokerttu commented Jun 27, 2023 • edited Loading

Pre-launch Checklist

Hixie commented Aug 22, 2023

thedalelakes commented Oct 5, 2023

jokerttu commented Oct 13, 2023

wangela commented Oct 30, 2023

jokerttu commented Oct 31, 2023 • edited Loading

stuartmorgan commented Nov 17, 2023

stuartmorgan left a comment

Choose a reason for hiding this comment

stuartmorgan commented Nov 17, 2023

apackin commented Jan 16, 2024

hellohuanlin commented Jan 17, 2024

jokerttu commented Jan 18, 2024 • edited Loading

This comment was marked as resolved.

stuartmorgan left a comment

Choose a reason for hiding this comment

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

stuartmorgan commented Aug 8, 2024

jokerttu commented Jun 27, 2023 •

edited

Loading

jokerttu commented Oct 31, 2023 •

edited

Loading

jokerttu commented Jan 18, 2024 •

edited

Loading