Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image_picker_ios] Update image picker UI test query for iOS 18 #7325

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Aug 6, 2024

The image picker UI changed from iOS 17 -> iOS 18 (beta), and there's an additional scrollview that wasn't present before.
Instead of selecting the first image in the first scroll view, instead select the image with the accessibility label that starts with "Photo":

      ↪︎Find: First Match
        Output: {
          Image, 0x10134f070, {{-0.0, 339.7}, {142.2, 142.3}}, label: 'Photo, March 30, 2018, 12:14 PM'
        }

This works on previous versions of iOS as well.

Fixes flutter/flutter#150220, found in Xcode 16 beta.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman
Copy link
Member Author

jmagman commented Aug 6, 2024

Passes on Xcode 16 beta 4 #7226

** TEST SUCCEEDED **

Testing started
Successfully ran iOS xctest for packages/image_picker/image_picker_ios/example

[packages/image_picker/image_picker_ios completed in 1m 54s]

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024
@auto-submit auto-submit bot merged commit 9ce1570 into flutter:main Aug 6, 2024
76 checks passed
@jmagman jmagman deleted the image-picker-test branch August 6, 2024 22:51
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 7, 2024
flutter/packages@551bde5...5cc0a01

2024-08-07 stuartmorgan@google.com [ci] Update repository for the release of Flutter 3.24 (flutter/packages#7331)
2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from b0850be to 80c2e84 (1397 revisions) (flutter/packages#7322)
2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.5 to 4.3.6 (flutter/packages#7330)
2024-08-07 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.7 to 1.13.12 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7189)
2024-08-07 joonas.kerttula@codemate.com [google_maps_flutter] Marker clustering support (flutter/packages#4319)
2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.15 to 3.26.0 (flutter/packages#7329)
2024-08-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 1dd7141 to 0a7f8af (23 revisions) (flutter/packages#7328)
2024-08-06 magder@google.com [image_picker_ios] Update image picker UI test query for iOS 18 (flutter/packages#7325)
2024-08-06 joonas.kerttula@codemate.com [google_maps_flutter] Add marker clustering support - iOS implementation (flutter/packages#6186)
2024-08-06 8014077+Frank3K@users.noreply.github.com [url_launcher] launchUrl always returns true for valid schemes on the web. (flutter/packages#7229)
2024-08-06 rexios@rexios.dev [google_maps_flutter] Add heatmap support (flutter/packages#3257)
2024-08-06 stuartmorgan@google.com [local_auth] Endorse macOS (flutter/packages#7274)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…er#153040)

flutter/packages@551bde5...5cc0a01

2024-08-07 stuartmorgan@google.com [ci] Update repository for the release of Flutter 3.24 (flutter/packages#7331)
2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from b0850be to 80c2e84 (1397 revisions) (flutter/packages#7322)
2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.5 to 4.3.6 (flutter/packages#7330)
2024-08-07 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.7 to 1.13.12 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7189)
2024-08-07 joonas.kerttula@codemate.com [google_maps_flutter] Marker clustering support (flutter/packages#4319)
2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.15 to 3.26.0 (flutter/packages#7329)
2024-08-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 1dd7141 to 0a7f8af (23 revisions) (flutter/packages#7328)
2024-08-06 magder@google.com [image_picker_ios] Update image picker UI test query for iOS 18 (flutter/packages#7325)
2024-08-06 joonas.kerttula@codemate.com [google_maps_flutter] Add marker clustering support - iOS implementation (flutter/packages#6186)
2024-08-06 8014077+Frank3K@users.noreply.github.com [url_launcher] launchUrl always returns true for valid schemes on the web. (flutter/packages#7229)
2024-08-06 rexios@rexios.dev [google_maps_flutter] Add heatmap support (flutter/packages#3257)
2024-08-06 stuartmorgan@google.com [local_auth] Endorse macOS (flutter/packages#7274)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
…er#153040)

flutter/packages@551bde5...5cc0a01

2024-08-07 stuartmorgan@google.com [ci] Update repository for the release of Flutter 3.24 (flutter/packages#7331)
2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from b0850be to 80c2e84 (1397 revisions) (flutter/packages#7322)
2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.5 to 4.3.6 (flutter/packages#7330)
2024-08-07 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.7 to 1.13.12 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7189)
2024-08-07 joonas.kerttula@codemate.com [google_maps_flutter] Marker clustering support (flutter/packages#4319)
2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.15 to 3.26.0 (flutter/packages#7329)
2024-08-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 1dd7141 to 0a7f8af (23 revisions) (flutter/packages#7328)
2024-08-06 magder@google.com [image_picker_ios] Update image picker UI test query for iOS 18 (flutter/packages#7325)
2024-08-06 joonas.kerttula@codemate.com [google_maps_flutter] Add marker clustering support - iOS implementation (flutter/packages#6186)
2024-08-06 8014077+Frank3K@users.noreply.github.com [url_launcher] launchUrl always returns true for valid schemes on the web. (flutter/packages#7229)
2024-08-06 rexios@rexios.dev [google_maps_flutter] Add heatmap support (flutter/packages#3257)
2024-08-06 stuartmorgan@google.com [local_auth] Endorse macOS (flutter/packages#7274)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…er#153040)

flutter/packages@551bde5...5cc0a01

2024-08-07 stuartmorgan@google.com [ci] Update repository for the release of Flutter 3.24 (flutter/packages#7331)
2024-08-07 engine-flutter-autoroll@skia.org Roll Flutter (stable) from b0850be to 80c2e84 (1397 revisions) (flutter/packages#7322)
2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.5 to 4.3.6 (flutter/packages#7330)
2024-08-07 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump io.mockk:mockk from 1.13.7 to 1.13.12 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#7189)
2024-08-07 joonas.kerttula@codemate.com [google_maps_flutter] Marker clustering support (flutter/packages#4319)
2024-08-07 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.15 to 3.26.0 (flutter/packages#7329)
2024-08-07 engine-flutter-autoroll@skia.org Manual roll Flutter from 1dd7141 to 0a7f8af (23 revisions) (flutter/packages#7328)
2024-08-06 magder@google.com [image_picker_ios] Update image picker UI test query for iOS 18 (flutter/packages#7325)
2024-08-06 joonas.kerttula@codemate.com [google_maps_flutter] Add marker clustering support - iOS implementation (flutter/packages#6186)
2024-08-06 8014077+Frank3K@users.noreply.github.com [url_launcher] launchUrl always returns true for valid schemes on the web. (flutter/packages#7229)
2024-08-06 rexios@rexios.dev [google_maps_flutter] Add heatmap support (flutter/packages#3257)
2024-08-06 stuartmorgan@google.com [local_auth] Endorse macOS (flutter/packages#7274)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: image_picker platform-ios
Projects
None yet
2 participants