-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version to 0.11 #1066
Update version to 0.11 #1066
Conversation
I am looking forward to that :) |
@devongovett Any chance you will be able to get this merged soon? I really need the infinite loop bug fix that this version would include. Thank you for your work on this great project! 💯 |
@blikblum Is there anyone else who can merge and release a new npm package? |
I can merge but is pointless because i cant publish it. |
Ah ok. Do you have any means by which to contact @devongovett to get this merged and published? I apologize for being insistent - trying to be patient but blocked by this at the moment. I really appreciate everybody's time and effort on this project and am trying to be cognizant of this project not being a day job. Trying to be patient :) |
I'll do it when I get home from work. Will also add @blikblum on npm for future releases. |
No only here. You can try pdfkit-next, i keep it for the unreleased fixes |
@devongovett Thank you so much!! 😄 👍 🎉 🎆 |
Thanks for that tip! I did not know about the pdfkit-next project. |
@blikblum FYI the tests are failing... |
Published anyway as v0.11.0. btw, @blikblum looks like you already had npm publish access. 😉
|
@devongovett Thanks for merging and publishing. When I pulled locally a couple weeks ago I noticed the integration tests were failing but I was not sure if that was expected or if that was an anomaly. If an anomaly, integration tests have been broken for at least a couple of recent commits to master. |
@devongovett Could we get a CI system setup? I don't think I have the permissions to do this but I think it would be of great use in improving code quality in merged PRs. Maybe there is one already? I don't think passing tests are enforced for merging though. Thoughts? |
The integration tests currently are not being used because the following shortcomings:
They played an important role in the migration from coffee to JS but now we are trying to improve the unit tests. My idea is to replace the integration tests for visual regression tests which does not suffer from above. Until now no time.
It would be a good thing. I don't know how to do but i can help merging stuff etc |
What kind of change does this PR introduce?
Set package version to 0.11 and update docs accordingly
Checklist:
Will let @devongovett merge and upload a new npm release