Update Jest Snapshots #1139
Closed
Update Jest Snapshots #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 26, 2020 16:01
This is exactly the problem of current tests that relies on snapshots: it will be different on each system depending on combination of OS node version etc. So this is not useful at all. Here you can find more thoughts |
|
Ok. So, from the thread in the link, until the tests are migrated to visual ones, is it worth to setup GitHub Actions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update the Jest snapshots, as all integration tests were failing because fof that.
All tests were re-ran and everything is OK now.
System where tests were ran: Ubuntu-18.04 on WSL on Windows 10
Checklist: