Improve error message for stream rate limit.

[cstyan]

Logs the rate limit, stream labels, and bytes for that push in the error/error message.

Signed-off-by: Callum Styan callumstyan@gmail.com

[owen-d]

While I do think it will be nice to have some more introspection here, I'd like to minimize costs on the hot path. Additionally, it'd be nice to use the bytesize types in the error messages to use human readable forms when possible.

[cstyan]

Rebased off main but tests are still failing, @owen-d if the error message improvement is still relevant I will fix the issues with tests, otherwise we can close.

[owen-d]

This is looking good, but since it's the hot path, I'd like to avoid unnecessarily re-checking the limit (which uses a mutex under the hood).

[cstyan]

Test failures are unrelated, see: #4344

[dannykopping]

Test failures are unrelated, see: #4344

@cstyan apologies, if you rebase then CI should be working since that PR has been merged.

[owen-d]

Suggested change

	// on each entry in the push (hot path) and we only use this value when logging entries that
	// passed the rate limit.
	// on each entry in the push (hot path) and we only use this value when logging entries over
	// the rate limit.