Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for stream rate limit. #4207

Merged
merged 8 commits into from
Sep 30, 2021
Merged

Improve error message for stream rate limit. #4207

merged 8 commits into from
Sep 30, 2021

Commits on Sep 22, 2021

  1. Improve error message for stream rate limit. 

    Signed-off-by: Callum Styan <callumstyan@gmail.com>
    @cstyan
    cstyan committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    fa887a1 View commit details
    Browse the repository at this point in the history

  2. Move stream rate limit error message to validation package. 

    Signed-off-by: Callum Styan <callumstyan@gmail.com>
    @cstyan
    cstyan committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    b4d273b View commit details
    Browse the repository at this point in the history

  3. Use ByteSize for number values in stream rate limit error so we can 

    print human readable rate limits and log line byte lengths.

Signed-off-by: Callum Styan <callumstyan@gmail.com>
    @cstyan
    cstyan committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    973c871 View commit details
    Browse the repository at this point in the history

  4. Fix lint issues. 

    Signed-off-by: Callum Styan <callumstyan@gmail.com>
    @cstyan
    cstyan committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    261039e View commit details
    Browse the repository at this point in the history

  5. Don't need to type assert twice. 

    Signed-off-by: Callum Styan <callumstyan@gmail.com>
    @cstyan
    cstyan committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    53dab59 View commit details
    Browse the repository at this point in the history

  6. Compare errors contents instead of doing error equals comparison 

    directly since the rate limit error is an RPC error.

Signed-off-by: Callum Styan <callumstyan@gmail.com>
    @cstyan
    cstyan committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    415652b View commit details
    Browse the repository at this point in the history

  7. Don't call Limit on hot path just to log the value in errors. 

    Signed-off-by: Callum Styan <callumstyan@gmail.com>
    @cstyan
    cstyan committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    f6e61ce View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Make coment about rate limit clearer. 

    Signed-off-by: Callum Styan <callumstyan@gmail.com>
    @cstyan
    cstyan committed Sep 30, 2021
    Configuration menu
    Copy the full SHA
    9110a74 View commit details
    Browse the repository at this point in the history