Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feature popups #313

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Improve feature popups #313

merged 4 commits into from
Jun 5, 2024

Conversation

dkastl
Copy link
Member

@dkastl dkastl commented Jun 5, 2024

Fixes #312

Changes proposed in this pull request:

  • Use PopupFeature overlay for better handling of position and style

Fixes #312

Signed-off-by: Daniel Kastl <daniel@georepublic.de>
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
@dkastl dkastl changed the base branch from main to next June 5, 2024 02:40
@dkastl dkastl self-assigned this Jun 5, 2024
@dkastl dkastl requested review from smellman and sanak June 5, 2024 02:41
@dkastl dkastl added the enhancement New feature or request label Jun 5, 2024
Copy link
Member

@sanak sanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
This is a lot better than previous [Edit] link!

@dkastl
Copy link
Member Author

dkastl commented Jun 5, 2024

Yes, the previous popup was just temporary and then it remained like this for long time ;-)
Especially for lines and polygons the position was weird, using the center point of the geometry.

@dkastl dkastl merged commit b525c88 into next Jun 5, 2024
10 checks passed
@dkastl dkastl deleted the dkastl/issue312 branch June 5, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve feature popups
2 participants