-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging does not work if written in lowercase(hazelcast.logging.level) [API-1740] #1432
Conversation
* Now if a config key is wrong the client fails fast
Changes: * Add datetime classes back, add default serializers, change year in codec to be int * Update tests and serialization * Update binary compat test * Add date/time to default serializers test * Adjust tests according to back compat * Rename sql service getter to getSql * Adjust timezone string * Add jet tests * Add constructors for datetime wrappers
* Add code sample checker * Update code samples to add client.shutdown
* Add distinct aggregator and tests * Update documentation
…ternal proxies (hazelcast#1023) * Fix DistributedObjectsTest failure due to internal proxies * Fix HazelcastClientTest
* Test adjustments around jet enabled config for backward compatbility tests * Fix datatypetest.js * Move createMapping to TestUtil and use it in all sql integration tests * Fix code samples
Can you update the documentation as well? https://github.com/srknzl/hazelcast-nodejs-client/blob/192b7be3059916f33e1c31c10612bdd54364498e/DOCUMENTATION.md#L654 |
…=> ${{ github.workspace }}
src/util/Util.ts
Outdated
@@ -69,7 +69,7 @@ export function shuffleArray<T>(array: T[]): void { | |||
|
|||
/** @internal */ | |||
export function enumFromString<T>(enumType: any, value: string): T { | |||
return enumType[value.toUpperCase()]; | |||
return enumType[value ? value.toUpperCase() : value]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not need this. Just ensure where we use enumFromString, value is a string indeed.
Codecov Report
@@ Coverage Diff @@
## master #1432 +/- ##
==========================================
+ Coverage 93.34% 93.37% +0.02%
==========================================
Files 466 466
Lines 16616 16623 +7
Branches 1348 1351 +3
==========================================
+ Hits 15511 15522 +11
+ Misses 803 798 -5
- Partials 302 303 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…) [API-1740] (hazelcast#1432) * Logging does not work if written in lowercase(hazelcast.logging.level) [API-1740]
This is simple change, I only add toUpperCase().
I am not sure we need extra test for this. I added a sample test for logging.