Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release v0.12.0 #1740

Merged
merged 6 commits into from
Jul 8, 2024
Merged

chore: release v0.12.0 #1740

merged 6 commits into from
Jul 8, 2024

Conversation

LucioFranco
Copy link
Member

@LucioFranco LucioFranco commented Jun 20, 2024 •
edited
Loading

v0.12.0 (2024-06-20)

This breaking release updates tonic to the hyper 1.0 ecosystem and also updates
to prost v0.13.0.

Features

  • build: Custom codecs for generated code (#1599) (18a2b30)
  • channel: Make channel feature additive (#1574) (b947e1a)
  • codec: Make error when not utf8 value in compression encoding (#1768) (f8e1f87)
  • Implement http_body::Body::size_hint for custom body (#1713) (9728c01)
  • Make boxed function public (#1754) (2cc868f)
  • Relax GrpcMethod lifetime (#1598) (68bf17d)
  • tls: Add ability to add multiple ca certificates (#1724) (3457f92)
  • tls: Use rustls_pki_types::CertificateDer to describe DER encoded certificate (#1707) (96a8cbc)
  • tls: Remove tls roots implicit configuration (#1731) (de73617)
  • transport: Make service router independent from transport (#1572) (da48235)
  • transport: Make transport server and channel independent (#1630) (654289f)
  • transport: Rename reexported axum body (#1752) (5d7bfc2)
  • Use http::Extensions directly (#1710) (ed95d27)

Bug Fixes

  • tonic: flush accumulated ready messages when status received (#1756) (d312dcc), closes #1423

BREAKING CHANGES

@LucioFranco LucioFranco requested review from djc and tottoto June 20, 2024 21:22
@aumetra aumetra mentioned this pull request Jun 21, 2024
Merged
4 tasks
@djc
Copy link
Collaborator

djc commented Jun 21, 2024 •
edited
Loading

Excited to get this out!

Previously the breaking changes were sorted before the features, probably better to keep it that way? Also would be nice to sort features from roughly most to least impactful.

Do we want to wait for #1727 which will also be breaking API?

@tottoto
Copy link
Collaborator

tottoto commented Jun 21, 2024

I would think it sounds good to wait for #1727 if possible.

howardjohn added a commit to howardjohn/ztunnel that referenced this pull request Jun 21, 2024
@howardjohn
dependencies: update to tonic 0.12
6d01599 
Pending hyperium/tonic#1740. DNM until its
released.

This lets us drop a few shims
@howardjohn howardjohn mentioned this pull request Jun 21, 2024
Merged
tottoto
tottoto reviewed Jun 23, 2024
View reviewed changes
CHANGELOG.md
Comment on lines +24 to +35
[v1.8.8]: https://github.com/fullstorydev/grpcurl/releases/tag/v1.8.8
[proto]: https://github.com/grpc/grpc/blob/master/src/proto/grpc/reflection/v1/reflection.proto
[grpcurl]: https://github.com/fullstorydev/grpcurl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of these link definitions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they just get auto generated by the tool I use 🤷

@dynst dynst mentioned this pull request Jun 23, 2024
Closed
1 task
@LucioFranco
Copy link
Member Author

Ah yes let me get #1727 in and then we can ship this. @djc for the changelog ordering, I don't have much time Im actually leaving for a week and a half tomorrow but once this is merged we can make changelog changes pretty easily.

@RaphaelDarley RaphaelDarley mentioned this pull request Jun 24, 2024
Merged
2 tasks
@abdolence abdolence mentioned this pull request Jun 26, 2024
Closed
1 task
@djc
Copy link
Collaborator

djc commented Jun 28, 2024

We merged #1757 instead of #1727. Probably good to just get this out and go from there?

@Millione
Copy link
Contributor

Millione commented Jul 1, 2024

Looking forward to the release！

@c-peters c-peters mentioned this pull request Jul 1, 2024
Open
@mladedav
Copy link

mladedav commented Jul 1, 2024

@djc Is this still waiting on something or is this ready to be released? Your comment seems to imply the latter but you're still listed as a pending reviewer.

@djc
Copy link
Collaborator

djc commented Jul 1, 2024

I pinged @LucioFranco out of band, but he had some time off. I only became a maintainer recently and want to make sure we're good for a release (and the release procedure).

@jdahlq jdahlq mentioned this pull request Jul 1, 2024
Closed
@tisonkun
Copy link
Contributor

tisonkun commented Jul 8, 2024

I can see that more PR merged during this period. Perhaps the CHANGELOG should be updated?

@LucioFranco
Copy link
Member Author

Sorry for the delay everyone, we wanted to get one last thing into this breaking release and it wasn't ready before I had some vacation so ended up missing the the time to cut the release. Will be shipping it ASAP now that I am back.

@LucioFranco LucioFranco added this pull request to the merge queue Jul 8, 2024
@LucioFranco LucioFranco removed this pull request from the merge queue due to a manual request Jul 8, 2024
@LucioFranco
Copy link
Member Author

Going to release prost and update tonic to the latest version as well before we release.

@rakshith-ravi
Copy link

it wasn't ready before I had some vacation so ended up missing the the time to cut the release

Take your time, my man. Vacation time is important to prevent burn out. Hope you had a good one. Cheers 🍻

@LucioFranco LucioFranco added this pull request to the merge queue Jul 8, 2024
Merged via the queue into master with commit 2eeca95 Jul 8, 2024
16 checks passed
@LucioFranco LucioFranco deleted the lucio/v0.12.0 branch July 8, 2024 17:54
howardjohn added a commit to howardjohn/ztunnel that referenced this pull request Jul 8, 2024
@howardjohn
dependencies: update to tonic 0.12
21a7283 
Pending hyperium/tonic#1740. DNM until its
released.

This lets us drop a few shims
@rtkay123 rtkay123 mentioned this pull request Jul 9, 2024
Open
1 task
@flokli flokli mentioned this pull request Jul 9, 2024
Merged
istio-testing pushed a commit to istio/ztunnel that referenced this pull request Jul 9, 2024
@howardjohn
dependencies: update to tonic 0.12 (#1170)
88320b0 
* dependencies: update to tonic 0.12

Pending hyperium/tonic#1740. DNM until its
released.

This lets us drop a few shims

* Use official

* udpate fuzz

* copyright

* no clone needed
tvlbot pushed a commit to tvlfyi/tvix that referenced this pull request Jul 20, 2024
@flokli
feat(tvix/nar-bridge): init
7b00a06 
This adds an implementation of nar-bridge in Rust.
Currently, only the GET parts are implemented.

Contrary to the Go variant, this doesn't try to keep a mapping from nar
hashes to root node in memory, it simply encodes the root node itself
(stripped by its basename) into the URL.

This pulls in a more recent version of axum than what we use in
tonic, causing two versions of http and hyper, however dealing with
`Body::from_stream` in axum 0.6 is much more annoying, and
hyperium/tonic#1740 suggests this will be fixed
soon.

Change-Id: Ia4c2dbda7cd3fdbe47a75f3e33544d19eac6e44e
Reviewed-on: https://cl.tvl.fyi/c/depot/+/11898
Autosubmit: flokli <flokli@flokli.de>
Reviewed-by: Brian Olsen <me@griff.name>
Tested-by: BuildkiteCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tottoto tottoto tottoto left review comments

@djc djc Awaiting requested review from djc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@LucioFranco @djc @tottoto @Millione @mladedav @tisonkun @rakshith-ravi