Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tonic 0.12 support #7

Merged
merged 1 commit into from
Jul 9, 2024
Merged

add tonic 0.12 support #7

merged 1 commit into from
Jul 9, 2024

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jul 9, 2024

This adds the tonic012 feature flag. The tonic 0.11 one is renamed to tonic_011 internally.

tonic release: hyperium/tonic#1740

I decided to explicitly suffix all tonic crates with their version, and added an explaining comment to the example - it's less chore when adding support for new versions.

@flokli flokli marked this pull request as draft July 9, 2024 08:26
@flokli flokli marked this pull request as ready for review July 9, 2024 08:29
This adds the `tonic012` feature flag. The tonic 0.11 one is renamed
to tonic_011 internally.
@vi
Copy link
Owner

vi commented Jul 9, 2024

How popular are those Tonic versions in apps?

Which Tonic versions should be retained in some tokio-listener next semver-major release?

@vi vi merged commit 7b6ea1d into vi:main Jul 9, 2024
@flokli flokli deleted the tonic-0.12 branch July 9, 2024 10:45
@flokli
Copy link
Contributor Author

flokli commented Jul 9, 2024

I think 0.12 might be the best bet currently, considering it switched to hyper 1.0.

@vi
Copy link
Owner

vi commented Jul 9, 2024

Published tokio-listener v0.4.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants