Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared Stops Support #552

Merged
merged 8 commits into from
Sep 6, 2023
Merged

Shared Stops Support #552

merged 8 commits into from
Sep 6, 2023

Conversation

miles-grant-ibigroup
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup commented Aug 3, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)

Description

Adds support for Shared Stops feature in OTP.

This PR relies on conveyal/gtfs-lib#391. Everything is erroring until that is updated in pom.xml. If you manually set the gtfs-lib version to 9903b3b63ad26d135b5a55cf17e595557db037bb, this PR will work.

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Aug 3, 2023
@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as ready for review August 8, 2023 14:36
br648
br648 requested changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Unit tests to comfirm each shared error type would be really good.

src/main/java/com/conveyal/datatools/manager/jobs/validation/SharedStopsValidator.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/datatools/manager/jobs/validation/SharedStopsValidator.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/datatools/manager/jobs/validation/SharedStopsValidator.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/datatools/manager/jobs/validation/SharedStopsValidator.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/datatools/manager/jobs/validation/SharedStopsValidator.java Show resolved Hide resolved
src/main/java/com/conveyal/datatools/manager/jobs/validation/SharedStopsValidator.java Show resolved Hide resolved
src/main/java/com/conveyal/datatools/manager/jobs/validation/SharedStopsValidator.java Outdated Show resolved Hide resolved
src/main/java/com/conveyal/datatools/manager/models/FeedVersion.java Outdated Show resolved Hide resolved
@br648 br648 assigned miles-grant-ibigroup and unassigned br648 Aug 9, 2023
@miles-grant-ibigroup
Copy link
Contributor Author

Good changes, thanks for the suggestions!

br648
br648 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@br648 br648 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nit. I'm approving, but think there should still be a unit test or two for this.

src/main/java/com/conveyal/datatools/manager/jobs/validation/SharedStopsValidator.java Outdated Show resolved Hide resolved
@br648 br648 assigned miles-grant-ibigroup and unassigned br648 Aug 14, 2023
@miles-grant-ibigroup miles-grant-ibigroup mentioned this pull request Aug 24, 2023
Merged
5 tasks
JymDyerIBI
JymDyerIBI approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@miles-grant-ibigroup miles-grant-ibigroup merged commit 41d808c into dev Sep 6, 2023
6 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the shared-stops-validator branch September 6, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@br648 br648 br648 approved these changes

@JymDyerIBI JymDyerIBI JymDyerIBI approved these changes

Assignees

@JymDyerIBI JymDyerIBI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @br648 @JymDyerIBI