Shared Stops Validator: Validate feed_id

[miles-grant-ibigroup]

Checklist

• Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
• Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
• The description lists all applicable issues this PR seeks to resolve
• The description lists any configuration setting(s) that differ from the default settings
• All tests and CI builds passing

Description

Builds on #552, only validating the shared stop if the feed_id of the feed matches the feed id of the row being validated

[br648]

I don't really see an alternative to using JDBCFetcher (this is the first use of it in DT). I guess the validation cannot be done in GTFS lib because you need the project's shared stop config and this transcends all feed versions so it can't be included there?

[miles-grant-ibigroup]

I don't really see an alternative to using JDBCFetcher (this is the first use of it in DT). I guess the validation cannot be done in GTFS lib because you need the project's shared stop config and this transcends all feed versions so it can't be included there?

Yeah we'd do all the validation in gtfs-lib but we don't have access to the feed info table in there

[br648]

I don't really see an alternative to using JDBCFetcher (this is the first use of it in DT). I guess the validation cannot be done in GTFS lib because you need the project's shared stop config and this transcends all feed versions so it can't be included there?

Yeah we'd do all the validation in gtfs-lib but we don't have access to the feed info table in there

Feed Info is loaded by GTFS-Lib it's just not made available in Feed. This could be updated to include feed info. But if I understand this correctly, GTFS Lib doesn't have the shard stop config so you'd still have a similar issue?

[br648]

Happy to approve after discussing with Miles. This approach keeps GTFS-Lib clean.

[binh-dam-ibigroup]

Works well. A nice-to-have would be to report the line number of the non-existing stop entity found.

[binh-dam-ibigroup]

Can you have this error be reported for the current line (instead of the entire feed) of the shared stops file?

[miles-grant-ibigroup]

The shared stops file is not in Postgres so the validator can't talk to it. the stopId links it to the stops file

[binh-dam-ibigroup]

I was thinking of line numbers because the shared stops file is processed line by line using configReader.readRecord().

[miles-grant-ibigroup]

Yes but unfortunately the validator doesn't know about those