Convert to PackageReferences instead of paket #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
commented
May 6, 2024
Comment on lines
+2
to
+18
| "name": "F# (.NET 7.0)", | ||
| "dockerFile": "Dockerfile", | ||
| "customizations": { | ||
| "vscode": { | ||
| "settings": { | ||
| "terminal.integrated.shell.linux": "/bin/bash", | ||
| "FSharp.useSdkScripts": true, | ||
| "FSharp.workspacePath": "FsAutoComplete.sln" | ||
| }, | ||
| "extensions": [ | ||
| "Ionide.Ionide-fsharp", | ||
| "ms-vscode.csharp" | ||
| ] | ||
| } | ||
| }, | ||
| "onCreateCommand": "dotnet restore" | ||
| } |
There was a problem hiding this comment.
I changed this because it referenced paket, but also because the json schema linting warnings said that the old format was incorrect.
Comment on lines
+166
to
+169
| "[msbuild]": { | ||
| "editor.formatOnSave": false | ||
| } | ||
| } |
There was a problem hiding this comment.
my extensions have been formatting project files - no more!
Comment on lines
+13
to
+16
| <!-- <packageSource key="dotnet8"> | ||
| <package pattern="FSharp.Core" /> | ||
| <package pattern="FSharp.Compiler.Service" /> | ||
| </packageSource> --> |
There was a problem hiding this comment.
on nightly, we can just uncomment this mapping and update/outdated/etc commands will just work for these two packages. we can run dotnet list package --outdated and see what the updateable versions are
| @@ -15,9 +15,9 @@ open Microsoft.FSharp.Core.LanguagePrimitives | |||
| /// | |||
| /// Note: As constant, because F# doesn't have `#define` | |||
| [<Literal>] | |||
| let private DEBUG = false | |||
There was a problem hiding this comment.
I was building with a 9 preview SDK and the inlining/visibility changes that Kevin made flagged a bunch of failed inlining in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.