-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to PackageReferences instead of paket #1285
base: main
Are you sure you want to change the base?
Changes from all commits
c29e94b
e34513d
d9566fe
491d065
50607c4
61f57c0
c7039f8
eec38d4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,24 @@ | ||
{ | ||
"version": 1, | ||
"isRoot": true, | ||
"tools": { | ||
"paket": { | ||
"version": "8.0.3", | ||
"commands": [ | ||
"paket" | ||
] | ||
}, | ||
"dotnet-reportgenerator-globaltool": { | ||
"version": "5.0.2", | ||
"commands": [ | ||
"reportgenerator" | ||
] | ||
}, | ||
"fantomas": { | ||
"version": "6.3.1", | ||
"commands": [ | ||
"fantomas" | ||
] | ||
}, | ||
"fsharp-analyzers": { | ||
"version": "0.25.0", | ||
"commands": [ | ||
"fsharp-analyzers" | ||
] | ||
} | ||
} | ||
{ | ||
"version": 1, | ||
"isRoot": true, | ||
"tools": { | ||
"dotnet-reportgenerator-globaltool": { | ||
"version": "5.0.2", | ||
"commands": [ | ||
"reportgenerator" | ||
] | ||
}, | ||
"fantomas": { | ||
"version": "6.3.1", | ||
"commands": [ | ||
"fantomas" | ||
] | ||
}, | ||
"fsharp-analyzers": { | ||
"version": "0.25.0", | ||
"commands": [ | ||
"fsharp-analyzers" | ||
] | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,18 @@ | ||
{ | ||
"name": "F# (.NET 7.0)", | ||
"dockerFile": "Dockerfile", | ||
"settings": { | ||
"terminal.integrated.shell.linux": "/bin/bash", | ||
"FSharp.useSdkScripts":true, | ||
"FSharp.workspacePath": "FsAutoComplete.sln" | ||
}, | ||
"onCreateCommand": "dotnet tool restore && dotnet restore", | ||
"extensions": [ | ||
"Ionide.Ionide-fsharp", | ||
"Ionide.Ionide-Paket", | ||
"ms-vscode.csharp" | ||
] | ||
} | ||
"name": "F# (.NET 7.0)", | ||
"dockerFile": "Dockerfile", | ||
"customizations": { | ||
"vscode": { | ||
"settings": { | ||
"terminal.integrated.shell.linux": "/bin/bash", | ||
"FSharp.useSdkScripts": true, | ||
"FSharp.workspacePath": "FsAutoComplete.sln" | ||
}, | ||
"extensions": [ | ||
"Ionide.Ionide-fsharp", | ||
"ms-vscode.csharp" | ||
] | ||
} | ||
}, | ||
"onCreateCommand": "dotnet restore" | ||
} | ||
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,4 +46,4 @@ test/FsAutoComplete.Tests.Lsp/TestResults/ | |
.tool-versions | ||
BenchmarkDotNet.Artifacts/ | ||
|
||
*.sarif | ||
*.sarif |
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,7 @@ | ||
{ | ||
"FSharp.excludeProjectDirectories": [ | ||
".git", | ||
"paket-files", | ||
"packages", | ||
"test/FsAutoComplete.IntegrationTests" | ||
"test/FsAutoComplete.IntegrationTests", | ||
], | ||
//otherwise take a lot of time to load proj inside | ||
//the test directories | ||
|
@@ -164,5 +162,8 @@ | |
"whitespaces", | ||
"xrtt", | ||
"xunit" | ||
] | ||
} | ||
], | ||
"[msbuild]": { | ||
"editor.formatOnSave": false | ||
} | ||
} | ||
Comment on lines
+166
to
+169
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. my extensions have been formatting project files - no more! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
<Project> | ||
<PropertyGroup> | ||
<ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally> | ||
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled> | ||
</PropertyGroup> | ||
<ItemGroup> | ||
<PackageVersion Include="BenchmarkDotNet" Version="0.13.12" /> | ||
<PackageVersion Include="CliWrap" Version="3.6.6" /> | ||
<PackageVersion Include="CommunityToolkit.HighPerformance" Version="8.2.2" /> | ||
<PackageVersion Include="Destructurama.FSharp" Version="2.0.0" /> | ||
<PackageVersion Include="Expecto.Diff" Version="10.2.1" /> | ||
<PackageVersion Include="Expecto" Version="10.2.1 " /> | ||
<PackageVersion Include="Fantomas.Client" Version="0.9.0" /> | ||
<PackageVersion Include="FSharp.Analyzers.SDK" Version="0.25.0" /> | ||
<PackageVersion Include="FSharp.Analyzers.Build" Version="0.2.0"/> | ||
<PackageVersion Include="FSharp.Compiler.Service" Version="43.8.200" /> | ||
<PackageVersion Include="FSharp.Core" Version="8.0.200" /> | ||
<PackageVersion Include="FSharp.Data.Adaptive" Version="1.2.15" /> | ||
<PackageVersion Include="FSharp.UMX" Version="1.1.0" /> | ||
<PackageVersion Include="FSharpx.Async" Version="1.14.1" /> | ||
<PackageVersion Include="FsToolkit.ErrorHandling.IcedTasks" Version="4.15.2" /> | ||
<PackageVersion Include="GitHubActionsTestLogger" Version="2.3.3" /> | ||
<PackageVersion Include="IcedTasks" Version="0.11.5" /> | ||
<PackageVersion Include="ICSharpCode.Decompiler" Version="8.2.0.7535" /> | ||
<PackageVersion Include="Ionide.Analyzers" Version="0.10.0" /> | ||
<PackageVersion Include="Ionide.KeepAChangelog.Tasks" Version="0.1.8" /> | ||
<PackageVersion Include="Ionide.LanguageServerProtocol" Version="0.5.0" /> | ||
<PackageVersion Include="Ionide.ProjInfo.ProjectSystem" Version="0.64.0" /> | ||
<PackageVersion Include="LinkDotNet.Stringbuilder" Version="1.20.0" /> | ||
<PackageVersion Include="Microsoft.CodeAnalysis" Version="4.9.2" /> | ||
<PackageVersion Include="Microsoft.Extensions.Caching.Memory" Version="8.0.0" /> | ||
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.9.0" /> | ||
<PackageVersion Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="1.8.1" /> | ||
<PackageVersion Include="OpenTelemetry.Instrumentation.Runtime" Version="1.8.0" /> | ||
<PackageVersion Include="OpenTelemetry" Version="1.8.1" /> | ||
<PackageVersion Include="Serilog.Sinks.Async" Version="1.5.0" /> | ||
<PackageVersion Include="Serilog.Sinks.Console" Version="5.0.1" /> | ||
<PackageVersion Include="Serilog.Sinks.File" Version="5.0.0" /> | ||
<PackageVersion Include="Serilog" Version="3.1.1" /> | ||
<PackageVersion Include="System.CommandLine" Version="2.0.0-beta4.22272.1" /> | ||
<PackageVersion Include="System.Reactive" Version="5.0.0" /> | ||
<PackageVersion Include="YoloDev.Expecto.TestSdk" Version="0.14.3" /> | ||
</ItemGroup> | ||
</Project> |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<configuration> | ||
<packageSources> | ||
<clear /> | ||
<add key="nuget" value="https://api.nuget.org/v3/index.json" /> | ||
<add key="dotnet8" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json" /> | ||
</packageSources> | ||
<packageSourceMapping> | ||
<!-- key value for <packageSource> should match key values from <packageSources> element --> | ||
<packageSource key="nuget"> | ||
<package pattern="*" /> | ||
</packageSource> | ||
<!-- <packageSource key="dotnet8"> | ||
<package pattern="FSharp.Core" /> | ||
<package pattern="FSharp.Compiler.Service" /> | ||
</packageSource> --> | ||
Comment on lines
+13
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. on nightly, we can just uncomment this mapping and update/outdated/etc commands will just work for these two packages. we can run |
||
</packageSourceMapping> | ||
</configuration> |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this because it referenced paket, but also because the json schema linting warnings said that the old format was incorrect.