Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for new Cloud functions, and tighter deviceid error checking #220

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

uzlonewolf
Copy link
Collaborator

README update as requested in #219, and a bit tighter error checking for the deviceid arguments.

…addition to None, and include a URL example in cloudrequest() comments
…addition to None, and include a URL example in cloudrequest() comments
@jasonacox jasonacox merged commit 1ddca16 into jasonacox:master Nov 22, 2022
@jasonacox
Copy link
Owner

Thank you!

Off topic a bit, but you got me thinking about expanding Cloud functions, should we expose short-cut lookup functions as well? I'm thinking about getname(id) getkey(id) getmac(id) etc. (though things like product_name and icon could be helpful or useless). All of this can be derived from getdevices() payload today, but wondering if these functions could be useful.

@uzlonewolf uzlonewolf deleted the cloud-logs branch November 23, 2022 07:02
@uzlonewolf
Copy link
Collaborator Author

I'm not feeling functions for stuff that's available from getdevices(), you just know someone is going to do something stupid and make a new request for every attribute for every device, and I'd rather not give Tuya a reason to restrict API access. If it's for something not available from getdevices() then sure, but with the sheer number of possible API calls I would only add them for things which would be rather useful (such as the device logs) or if we get a request for it.

@uzlonewolf
Copy link
Collaborator Author

Oh, and Happy Thanksgiving!

@jasonacox
Copy link
Owner

Thanks @uzlonewolf !! Happy Thanksgiving to you too! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants