Update README for new Cloud functions, and tighter deviceid error checking

README.md

@@ -208,12 +208,15 @@ Functions:
 
     Cloud
         setregion(apiRegion)
+	cloudrequest(url, action=[POST if post else GET], post={}, query={})
         getdevices(verbose=False)
         getstatus(deviceid)
         getfunctions(deviceid)
         getproperties(deviceid)
         getdps(deviceid)
         sendcommand(deviceid, commands)
+	getconnectstatus(deviceid)
+	getdevicelog(deviceid, start=[now - 1 day], end=[now], evtype="1,2,3,4,5,6,7,8,9,10", size=100, params={})
 ```
 
 ### TinyTuya Error Codes
@@ -389,6 +392,17 @@ result = c.sendcommand(id,commands)
 print("Results\n:", result)
 ```
 
+Up to one week of device logs can also be pulled from the Cloud.  By default getdevicelog() will pull 1 day of logs or 100 log entries, whichever comes first.
+
+```python
+import tinytuya
+import json
+
+c = tinytuya.Cloud()
+r = c.getdevicelog( '00112233445566778899' )
+print( json.dumps(r, indent=2) )
+```
+
 ### Encryption notes
 
 These devices uses AES encryption which is not available in the Python standard library. There are three options:

tinytuya/Cloud.py

@@ -252,7 +252,7 @@ def _getuid(self, deviceid=None):
         # Get user ID (UID) for deviceid
         if not self.token:
             return self.error
-        if deviceid is None:
+        if not deviceid:
             return error_json(
                 ERR_PARAMS,
                 "_getuid() requires deviceID parameter"
@@ -281,7 +281,7 @@ def cloudrequest(self, url, action=None, post=None, query=None):
         Make a generic cloud request and return the results.
 
         Args:
-          url:    Required.  The URL to fetch.
+          url:    Required.  The URL to fetch, i.e. "/v1.0/devices/0011223344556677/logs"
           action: Optional.  GET, POST, DELETE, or PUT.  Defaults to GET, unless POST data is supplied.
           post:   Optional.  POST body data.  Will be fed into json.dumps() before posting.
           query:  Optional.  A dict containing query string key/value pairs.
@@ -360,7 +360,7 @@ def filter_devices( self, devs, ip_list=None ):
     def _getdevice(self, param='status', deviceid=None):
         if not self.token:
             return self.error
-        if deviceid is None:
+        if not deviceid:
             return error_json(
                 ERR_PARAMS,
                 "Missing DeviceID Parameter"
@@ -398,7 +398,7 @@ def getdps(self, deviceid=None):
         """
         if not self.token:
             return self.error
-        if deviceid is None:
+        if not deviceid:
             return error_json(
                 ERR_PARAMS,
                 "Missing DeviceID Parameter"
@@ -418,10 +418,10 @@ def sendcommand(self, deviceid=None, commands=None):
         """
         if not self.token:
             return self.error
-        if deviceid is None or commands is None:
+        if (not deviceid) or (not commands):
             return error_json(
                 ERR_PARAMS,
-                "Missing DeviceID and Command Parameters"
+                "Missing DeviceID and/or Command Parameters"
             )
         uri = 'iot-03/devices/%s/commands' % (deviceid)
         response_dict = self._tuyaplatform(uri,action='POST',post=commands)
@@ -438,7 +438,7 @@ def getconnectstatus(self, deviceid=None):
         """
         if not self.token:
             return self.error
-        if deviceid is None:
+        if not deviceid:
             return error_json(
                 ERR_PARAMS,
                 "Missing DeviceID Parameter"
@@ -452,7 +452,7 @@ def getconnectstatus(self, deviceid=None):
             )
         return(response_dict["result"]["online"])
 
-    def getdevicelog(self, devid, start=None, end=None, evtype=None, size=100, params={}):
+    def getdevicelog(self, deviceid=None, start=None, end=None, evtype=None, size=100, params={}):
         """
         Get the logs for a device.
 
@@ -471,6 +471,11 @@ def getdevicelog(self, devid, start=None, end=None, evtype=None, size=100, param
         Returns:
           Response from server
         """
+        if not deviceid:
+            return error_json(
+                ERR_PARAMS,
+                "Missing DeviceID Parameter"
+            )
         if not end:
             end = int(time.mktime(time.gmtime()))
         if not start:
@@ -493,4 +498,4 @@ def getdevicelog(self, devid, start=None, end=None, evtype=None, size=100, param
         if 'query_type' not in params:
             params['query_type'] = 1
 
-        return self.cloudrequest( '/v1.0/devices/%s/logs' % devid, query=params)
+        return self.cloudrequest( '/v1.0/devices/%s/logs' % deviceid, query=params)