Enable storing multiple compiled patterns at once #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Out of bounds fixes.
Check for correct python2 binary in Makefile
Fix pattern ".?" issues
hopefully fixes #12
Update re.c
fixing typo, noticed by @tobermory -> #19
Adding failing test-case for question-mark '?', brought to my attention by @tobermory in #20
Update re.c for #20
ghost
closed this
ghost
deleted the
|
I have tidied this pull request up and resubmitted. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Firstly, thank you for generously publishing this code in the public domain.
Here are changes which resolve #3, which also change the public API. In summary, we now have:
typedef regex_t re_t[MAX_REGEXP_OBJECTS];int re_compile(re_t re_compiled, const char* pattern);Here is a snippet which demonstrates the new functionality:
https://gist.github.com/jmher/95bbc3b286bf5eb40fee304e95c7ddc6
JM