-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes coverall, #1755 #1762
Fixes coverall, #1755 #1762
Conversation
/kind bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jgrumboe it looks like this is working properly based on the status check result.
One small request, could you move the go test
as a new Make target and call that in the ci?
@jgrumboe please rebase. I promise that I will make the changelog experience better 😅 |
/hold |
/unhold |
@vinny-sabatini I just moved the coverprofile argument to the test target of the Makefile. I didn't create a new target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgrumboe, njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
**Fixes test coverage with coveralls **
This PR fixes the github CI action to generate a coverprofile.
Fixes #1755
Checklist