Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes coverall, #1755 #1762

Merged
merged 7 commits into from
Sep 1, 2020
Merged

Fixes coverall, #1755 #1762

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7bf381f
Fixes coverall, #1755
jgrumboe Aug 28, 2020
5eceb08
Updated CHANGELOG
jgrumboe Aug 28, 2020
541c22e
Fixes coverall, #1755
jgrumboe Aug 28, 2020
26f2bad
Updated CHANGELOG because of rebasing
jgrumboe Aug 28, 2020
6f5ef2a
Moved coverprofile creation into Makefile
jgrumboe Sep 1, 2020
61933ef
Merge branch 'fix-coverall' of https://github.com/porscheinformatik/e…
jgrumboe Sep 1, 2020
fb80737
Merge branch 'master' into fix-coverall
jgrumboe Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ jobs:
curl -sSfL https://raw.github.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.30.0
make lint

- name: Coverage
uses: shogo82148/actions-goveralls@v1

- name: Test
run: make test


- name: Send coverage
uses: shogo82148/actions-goveralls@v1
with:
path-to-profile: profile.cov
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- Update all container registry references to use k8s.gcr.io @seanmalloy
- Provide available prometheus metrics in documentation @vinny-sabatini
- Fix index out of range when hostname has no dots (#1756) @chemasan
- Fixes test coverage with coveralls (#1755) @jgrumboe

## v0.7.3 - 2020-08-05

Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ lint: licensecheck go-lint
.PHONY: verify test

test:
go test -race ./...
go test -race -coverprofile=profile.cov ./...

# The build targets allow to build the binary and docker image
.PHONY: build build.docker build.mini
Expand Down