Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive Design, Footers do not snap to bottom of screen on mobile devices #15118

Closed
gwharton opened this issue May 9, 2018 · 14 comments
Closed
Labels
Component: Ui Event: dmcdindia Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@gwharton
Copy link
Contributor

gwharton commented May 9, 2018

When you view Magento pages on a mobile device, the footers do not snap to the bottom of the page. They do in tablet and desktop modes.

Preconditions

  1. Stock Magento 2.2.4
  2. Luma Theme

Steps to reproduce

  1. View on mobile device, or browser with Responseive design mode
  2. Ensure screen size is taller than content

Expected result

  1. Footer should be at bottom of screen

Actual result

  1. Footer does not follow bottom of screen.

Here is a video

https://www.youtube.com/watch?v=pYe7uocqkTw

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 9, 2018
@gwharton gwharton changed the title Responsive Design, Footers do not snap to bottom of screen in mobile devices Responsive Design, Footers do not snap to bottom of screen on mobile devices May 9, 2018
@DougPlumley
Copy link

Would this be related to the issue I've seen when scrolling to the bottom of a page on mobile and it snaps your view back up midpage?

@chirag-wagento
Copy link
Contributor

I am working on this at #dmcdindia

@magento-engcom-team
Copy link
Contributor

Hi @gwharton. Thank you for your report.
The issue has been fixed in #15353 by @chirag-wagento in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.5 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label May 23, 2018
magento-team pushed a commit that referenced this issue May 23, 2018
…ices #15118 #15353

 - Merge Pull Request #15353 from chirag-wagento/magento2:responsive-design-footers
 - Merged commits:
   1. eef111f
@gwharton gwharton reopened this May 23, 2018
@gwharton
Copy link
Contributor Author

I don't agree with the resolution of this issue to be honest.

Placing both footer and copyright at position absolute, bottom: 0 means that the footer is partially obscured by the copyright. It also means that pages that have content larger than one page, the footer stays on screen and the content disappears down behind the footer.

I would have though the best implementation would be to use the same method as the desktop layout and instead of the implemented changes, you would have something like this instead, to make the page full height, and grow the main content panel, effectively pushing the footer and copyright sections to the bottom.

.media-width(@extremum, @break) when (@extremum = 'max') and (@break = @screen__m) {
  html,
  body {
      height: 100%; // Stretch screen area for sticky footer
  }
  .page-wrapper {
    display: flex;
    flex-direction: column;
    min-height: 100%;
  }
  .page-main {
    flex-grow: 1;
    flex-shrink: 0;
    flex-basis: auto;
    -webkit-flex-grow: 1;
    -webkit-flex-shrink: 0;
    -webkit-flex-basis: auto;
  }
}

@chirag-wagento
Copy link
Contributor

@gwharton, Thanks for review my code.
I have fixed it and generated a new pull request
@magento-engcom-team can you please test and review my new code again

Thanks

@gwharton
Copy link
Contributor Author

Updated PR #15471 working perfectly for me. Thanks @chirag-wagento

@magento-engcom-team magento-engcom-team added the Progress: PR Created Indicates that Pull Request has been created to fix issue label May 26, 2018
@gwharton gwharton removed the Fixed in 2.2.x The issue has been fixed in 2.2 release line label May 26, 2018
vijay-wagento pushed a commit to vijay-wagento/magento2 that referenced this issue Jun 4, 2018
vijay-wagento added a commit to vijay-wagento/magento2 that referenced this issue Jun 4, 2018
[Forwardport] Responsive Design Footers bottom of screen on mobile devices magento#15118
vijay-wagento pushed a commit to vijay-wagento/magento2 that referenced this issue Jun 4, 2018
vijay-wagento added a commit to vijay-wagento/magento2 that referenced this issue Jun 4, 2018
[Backport] Responsive Design Footers bottom of screen on mobile devices magento#15118
@ghost ghost self-assigned this Jul 10, 2018
@ghost ghost added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Component: Ui labels Jul 10, 2018
@ghost
Copy link

ghost commented Jul 10, 2018

@gwharton, thank you for your report.
We've acknowledged the issue and added to our backlog.

@sidolov
Copy link
Contributor

sidolov commented Jul 24, 2018

Hi @gwharton. Thank you for your report.
The issue has been fixed in #16994 by @ihor-sviziev in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@sidolov sidolov added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jul 24, 2018
magento-engcom-team added a commit that referenced this issue Jul 24, 2018
… on mobile devices #15118 #16994

 - Merge Pull Request #16994 from ihor-sviziev/magento2:2.3-develop-PR-port-15353
 - Merged commits:
   1. f7228d0
@gwharton
Copy link
Contributor Author

Just to confirm. This isnt fixed. The resolution applied to 2.2 and 2.3 is not a good one and needs relooking at.

@denistrator
Copy link

@sidolov +1. Please review #16994. It doesn't fix the issue but creates a new one

@sidolov
Copy link
Contributor

sidolov commented Jul 24, 2018

Hi @denistrator , I guess your PR #17006 contains fix for this issue and currently in status Delivery in progress. Also we have similar PR for the same problem: #16981

@sidolov
Copy link
Contributor

sidolov commented Jul 27, 2018

Hi @gwharton. Thank you for your report.
The issue has been fixed in #17006 by @denistrator in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@sidolov sidolov added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jul 27, 2018
@sidolov sidolov closed this as completed Jul 27, 2018
magento-engcom-team added a commit that referenced this issue Jul 27, 2018
#15118 #17006

 - Merge Pull Request #17006 from denistrator/magento2:#15118
 - Merged commits:
   1. 33a67bc
@gwharton
Copy link
Contributor Author

Fix PR #17006 working well for me.

@sidolov
Copy link
Contributor

sidolov commented Sep 4, 2018

Hi @gwharton. Thank you for your report.
The issue has been fixed in #17809 by @nmalevanec in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

magento-engcom-team added a commit that referenced this issue Sep 4, 2018
…ky footer; fixes #15118 #17809

 - Merge Pull Request #17809 from nmalevanec/magento2:2.3-develop-PR-port-17006
 - Merged commits:
   1. 5ca1f9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Ui Event: dmcdindia Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: PR Created Indicates that Pull Request has been created to fix issue Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

6 participants