Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Responsive Design Footers bottom of screen on mobile devices #15118 #15730

Conversation

vijay-wagento
Copy link

Original Pull Request

#15353
Solved footer issue for mobile view

Description

Solved footer issue for mobile view

Fixed Issues (if relevant)

  1. Responsive Design, Footers do not snap to bottom of screen on mobile devices #15118: Responsive Design, Footers do not snap to bottom of screen on mobile devices
  2. ...

Manual testing scenarios

  1. Check footer in mobile

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 4, 2018
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 4, 2018

CLA assistant check
All committers have signed the CLA.

@VladimirZaets
Copy link
Contributor

Hi @vijay-wagento. This fix has some problems. First of all, if page content will be less than 100% of page size that footer will not be on the bottom of the page.
Also if the page will contain some content in the bottom the content will be overlapped by footer and will never be visible.
The right way to fix it presented in this PR

@VladimirZaets
Copy link
Contributor

@vijay-wagento, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants