Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed due to DateTest #928

Closed
snky1987 opened this issue Jan 7, 2015 · 2 comments
Closed

Failed due to DateTest #928

snky1987 opened this issue Jan 7, 2015 · 2 comments
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@snky1987
Copy link

snky1987 commented Jan 7, 2015

I already fixed this issue with following set of tests locally but ofc it fails Travis so it may be ignored by team (as documentation says).

Issue is that DateTest::testGetValue() fails because '5/18/14 pm' is expected but '5/18/14 PM' is actual.
and the second fail is because '12:08 pm' is expected but '12:08 PM' is actual.

There is a pull request #923 created with lower case am/pm in it.

due to this error I am unable to create pull request about anything from setup directory.

...or maybe I do something wrong ?

@monkeysee
Copy link
Contributor

Created internal issue: MAGETWO-33026

@muasir muasir added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 23, 2015
@sshrewz
Copy link

sshrewz commented Mar 26, 2015

@snky1987, since this issue has been resolved in #913, we will go ahead and close this issue. Should you have any questions, please don't hesitate to let us know.

@sshrewz sshrewz closed this as completed Mar 26, 2015
magento-team pushed a commit that referenced this issue Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

5 participants