Specify date fixture and fix expectations #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix date_format expectation for month part * Make test independent of current time
This was referenced Jan 5, 2015
|
CR: passed |
maksek
pushed a commit
that referenced
this pull request
Jan 6, 2015
Specify date fixture and fix expectations (MAGETWO-32328)
Closed
magento-team
pushed a commit
that referenced
this pull request
Apr 11, 2017
[TSG] MAGETWO-65339: [Backport] - [Performance] Optimize "Is Salable" check on Category page for Configurable Product - for 2.1.6
fe-lix-
pushed a commit
to fe-lix-/magento2
that referenced
this pull request
Apr 29, 2018
…d-into-reservation-order-id Add Order Id into reservation's Metadata
strell
added a commit
to strell/magento2
that referenced
this pull request
Sep 22, 2019
- Added new field genderV2 with the type of enum - Added data mapper in order to turn the gender value into genderV2 value and vice-versa - Extended api-functional tests
strell
added a commit
to strell/magento2
that referenced
this pull request
Sep 22, 2019
… the gender upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test passes if the current date is during October - December (10-12), but fails for January - September (1-9)
In the test
Magento\Framework\Data\Form\Element\DateTest::testGetValue()the expected format for the month part for the formatMagento\Framework\Stdlib\DateTime\TimezoneInterface::FORMAT_TYPE_SHORTis specifíed asmwhich is the placeholder for "Numeric representation of a month, with leading zeros".However, in the file
vendor/magento/zendframework1/library/Zend/Locale/Data/en.xmlthe code for the month part matching the FORMAT_TYPE_SHORT isM.According to the Zend Framework manual, this placeholder stands for "Month (Number of the month, one or two digits)".
(That placeholder value
Mis represented by the class constantZend_Date::MONTH_SHORT).So the month values are expected to have a leading zero, but Zend_Date formats them without the leading zero.