Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix icon color variable naming #16559

Merged
merged 2 commits into from
Jul 13, 2018
Merged

fix icon color variable naming #16559

merged 2 commits into from
Jul 13, 2018

Conversation

Karlasa
Copy link
Contributor

@Karlasa Karlasa commented Jul 5, 2018

Search icon should not be defined by minicart icon colors and header icon variables should used instead.

Description

Changed search icon to use header icons color variables

Fixed Issues (if relevant)

Manual testing scenarios

visually nothing changed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jul 5, 2018
This was referenced Jul 12, 2018
Merged
Merged
magento-engcom-team added a commit that referenced this pull request Jul 12, 2018
@magento-engcom-team
ENGCOM-2286: [backport] #16559 fix icon color variable naming #16735
3711bde 
 - Merge Pull Request #16735 from Karlasa/magento2:BP-PR-16559
 - Merged commits:
   1. 818519e
   2. c11e329
   3. 59a9f32
magento-engcom-team pushed a commit that referenced this pull request Jul 12, 2018
@VladimirZaets
ENGCOM-2286: [backport] #16559 fix icon color variable naming #16735
3496441
magento-engcom-team pushed a commit that referenced this pull request Jul 12, 2018
🔃 [EngCom] Public Pull Requests - 2.1-develop
756dc8c 
Accepted Public Pull Requests:
 - #16720: [Backport] Fix for #12081: missing translations in the js-translations.json (by @sanganinamrata)
 - #16731: [Backport] Removed extra code (by @gelanivishal)
 - #16735: [backport] #16559 fix icon color variable naming  (by @Karlasa)


Fixed GitHub Issues:
 - #12081: Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. (reported by @jhruehl) has been fixed in #16720 by @sanganinamrata in 2.1-develop branch
   Related commits:
     1. aa0e051
@magento-engcom-team magento-engcom-team merged commit aff94d2 into magento:2.2-develop Jul 13, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 13, 2018
@VladimirZaets
ENGCOM-2196: fix icon color variable naming #16559
23a5c7e
@magento-engcom-team
Copy link
Contributor

Hi @Karlasa. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@Karlasa Karlasa deleted the variables-naming-fix branch July 21, 2018 08:05
magento-engcom-team added a commit that referenced this pull request Jul 24, 2018
@magento-engcom-team
ENGCOM-2287: [forwardport] #16559 fix icon color variable naming #16734
1a8bdb8 
 - Merge Pull Request #16734 from Karlasa/magento2:FP-PR16559
 - Merged commits:
   1. e0bd487
   2. 15f6269
magento-engcom-team pushed a commit that referenced this pull request Jul 24, 2018
ENGCOM-2287: [forwardport] #16559 fix icon color variable naming #16734
4185450
magento-engcom-team pushed a commit that referenced this pull request Jul 24, 2018
🔃 [EngCom] Public Pull Requests - 2.3-develop
d120ac1 
Accepted Public Pull Requests:
 - #16893: [Forwardport] FIX for issue#14869 - Wrong price at backend after update (by @mage2pratik)
 - #17020: [Forwardport] hide cookie notice instead of reloading site (by @torhoehn)
 - #17014: [Forwardport] Fixes white color coding standard. (by @chirag-wagento)
 - #17016: [Forwardport] Avoid undefined index warning when using uppercase reserved word (by @FreekVandeursen)
 - #17017: [Forwardport] Wrong namespace defined in compare.phtml (by @ronak2ram)
 - #16997: [Forwardport] Corrected Magento_Framework's test xml file. (by @ihor-sviziev)
 - #16996: [Forwardport] Updated Magento_Newsletter's block file. (by @ihor-sviziev)
 - #16994: [Forwardport] Responsive Design Footers bottom of screen on mobile devices #15118 (by @ihor-sviziev)
 - #16993: [Forwardport] FIXED - appended payment code to ID field to make it unique (by @ihor-sviziev)
 - #16998: [Forwardport] Added 'title' attribute to 'a' link. (by @ihor-sviziev)
 - #16973: [Forwardport] Removed double occurrence of  keywords in sentences. (by @gelanivishal)
 - magento/graphql-ce#126: 120 implement store configs coverage (by @VitaliyBoyko)
 - magento/graphql-ce#99: #96 Make category query compatible with staging (by @roma-glushko)
 - #16734: [forwardport] #16559 fix icon color variable naming  (by @Karlasa)


Fixed GitHub Issues:
 - #14869: M 2.2.3 price per website - wrong price at backend by a create order after update (reported by @Webroju) has been fixed in #16893 by @mage2pratik in 2.3-develop branch
   Related commits:
     1. 49926d7
     2. 35b968e

 - #15118: Responsive Design, Footers do not snap to bottom of screen on mobile devices (reported by @gwharton) has been fixed in #16994 by @ihor-sviziev in 2.3-develop branch
   Related commits:
     1. f7228d0

 - #13692: In payment step of checkout I cannot unselect #billing-save-in-address-book checkbox in non-first payment method (reported by @NeosKnowledgeBasePluswerk) has been fixed in #16993 by @ihor-sviziev in 2.3-develop branch
   Related commits:
     1. a659f4b

 - #120: Default trigger coupon via URL (reported by @seansan) has been fixed in magento/graphql-ce#126 by @VitaliyBoyko in 2.3-develop branch
   Related commits:
     1. e1f53d4
     2. 5229cd6
     3. af4b258
     4. 3b64955
     5. b5a2a98
     6. e85a6e5
     7. 8f3c6e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@Karlasa @magento-engcom-team @VladimirZaets