Change interpret() return value to conform with Layout\ReaderInterface #908
Conversation
|
Test failure is because of the issue fixed in #913, not because of this PR. |
Change View\Layout\Reader\Remove::interpret() return value to conform with Layout\ReaderInterface::interpret()
|
@Vinai, for the future if you want to deliver to Magento source code some similar changes it will be better to combine them in one PR instead of creating a bunch of different PRs. |
|
CR: passed |
Change interpret() return value to conform with Layout\ReaderInterface
|
Great! From other projects I have the experience they prefer small, atomic PRs. |
|
It depends on changes. In your case when you work on one issue (compatibility with Layout\ReaderInterface) and fix it in a few places it is preferable to have one PR. But if the changes are not related, and fix a few different issues, separate PR for each issue should be created. |
This PR to the develop branch replaces #754.
The only change is the return type of the interpret() method so it conforms to the interface declaration.