add missing ExtraHosts to gateway exec #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coryb
force-pushed
the
gateway-exec-extra-hosts
branch
from
da7c266
to
396b36f
Compare
coryb
commented
Aug 3, 2021
coryb
force-pushed
the
gateway-exec-extra-hosts
branch
from
396b36f
to
74df727
Compare
tonistiigi
reviewed
Aug 10, 2021
Also adding tests for ExtraHosts and NetMode via gateway exec Signed-off-by: Cory Bennett <cbennett@netflix.com>
coryb
force-pushed
the
gateway-exec-extra-hosts
branch
from
74df727
to
d581aa7
Compare
Signed-off-by: Cory Bennett <cbennett@netflix.com>
coryb
force-pushed
the
gateway-exec-extra-hosts
branch
from
d581aa7
to
2893203
Compare
Updated, sorry for the delay, been a busy week. |
tonistiigi
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding tests for ExtraHosts and NetMode via gateway exec
Found the missing ExtraHosts while doing more manual integration and testing with gateway exec.