add host instructions to gateway exec for debugging into container
#266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronlehmann
reviewed
Aug 3, 2021
| @@ -598,6 +599,11 @@ func ExecWithFS(ctx context.Context, cln *client.Client, fs Filesystem, r io.Rea | |||
| securityMode = o.SecurityMode | |||
| case llbutil.NetworkOption: | |||
| netMode = o.NetMode | |||
| case llbutil.HostOption: | |||
There was a problem hiding this comment.
Let's also add the equivalent to ExecWithSolveErr. It looks like ExtraHosts is exposed under Meta in ExecOp.
There was a problem hiding this comment.
nice catch, forgot about that one. Fixed.
coryb
force-pushed
the
gateway-exec-extra-hosts
branch
from
2c6ffb0
to
ce30850
Compare
aaronlehmann
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates to use PR branch for buildkit with this feature. Will update after PR moby/buildkit#2294 is merged.