Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover increase delta and fix safe sub #1362

Merged
merged 22 commits into from
Oct 31, 2022
Merged

Recover increase delta and fix safe sub #1362

merged 22 commits into from
Oct 31, 2022

Conversation

MerlinEgalite
Copy link
Contributor

@MerlinEgalite MerlinEgalite changed the title Recover/increase delta and fix safe sub Recover increase delta and fix safe sub Oct 13, 2022
@MerlinEgalite MerlinEgalite marked this pull request as ready for review October 14, 2022 07:24
@MerlinEgalite MerlinEgalite requested review from a team October 14, 2022 07:24
@MerlinEgalite MerlinEgalite self-assigned this Oct 14, 2022
Rubilmax
Rubilmax approved these changes Oct 14, 2022
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was trickier to review, because of outdated branches on mirrored PRs. But anyway, done!

Base automatically changed from fix/lens-visibility to fix/lens-aave-v2 October 15, 2022 08:22
Base automatically changed from fix/lens-aave-v2 to refactor/reset-state October 17, 2022 14:56
@MerlinEgalite MerlinEgalite changed the base branch from refactor/reset-state to dev October 17, 2022 16:36
@MerlinEgalite MerlinEgalite changed the base branch from dev to upgrade-0 October 19, 2022 10:09
MathisGD
MathisGD reviewed Oct 23, 2022
View reviewed changes
Copy link
Collaborator

@MathisGD MathisGD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments (should be applied on all the 3 protocols)

contracts/aave-v2/ExitPositionsManager.sol Outdated Show resolved Hide resolved
contracts/aave-v2/ExitPositionsManager.sol Outdated Show resolved Hide resolved
contracts/aave-v2/MorphoGovernance.sol Outdated Show resolved Hide resolved
contracts/aave-v2/MorphoGovernance.sol Outdated Show resolved Hide resolved
Rubilmax
Rubilmax approved these changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@Rubilmax Rubilmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foundry-storage-check is failing and I know why. I'll fix this asap

@Rubilmax Rubilmax mentioned this pull request Oct 24, 2022
Merged
1 task
MathisGD
MathisGD reviewed Oct 28, 2022
View reviewed changes
contracts/compound/PositionsManager.sol Outdated Show resolved Hide resolved
contracts/compound/PositionsManager.sol Outdated Show resolved Hide resolved
contracts/aave-v2/ExitPositionsManager.sol Outdated Show resolved Hide resolved
MathisGD
MathisGD requested changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the cached indexes on Compound.

@MathisGD
Copy link
Collaborator

You marked my comments as resolved but didn’t resolved them @MerlinEgalite

@MerlinEgalite MerlinEgalite merged commit 8e1ffe8 into upgrade-0 Oct 31, 2022
@MerlinEgalite MerlinEgalite deleted the recover/increase-delta-and-fix-safe-sub branch October 31, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisGD MathisGD MathisGD approved these changes

@Rubilmax Rubilmax Rubilmax approved these changes

@QGarchery QGarchery QGarchery approved these changes

@pakim249CAL pakim249CAL Awaiting requested review from pakim249CAL

Assignees

@MerlinEgalite MerlinEgalite

Labels
👻 aave-v2 👻 aave-v3 🟢 compound 🧪 testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MerlinEgalite @Rubilmax @MathisGD @QGarchery @pakim249CAL