Fix storage checks for interfaces #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubilmax
requested review from
MathisGD,
MerlinEgalite,
pakim249CAL and
QGarchery
QGarchery
approved these changes
Oct 24, 2022
MathisGD
approved these changes
Oct 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
The CI fails in #1362 because we've modified some interfaces and thus forge reports them as different variable types in the storage... But in reality, both are stored as addresses and this would not have raised an error if an address was used instead, so I modified
foundry-storage-checkto bypass this checkChangelog: Rubilmax/foundry-storage-check@v2...v2.1
To Do
morpho-tokenized-vaultsafter approval