Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joining document after it was renamed inside editor causes document conflict and potential data loss #3492

Closed
eszkadev opened this issue Feb 22, 2024 · 0 comments · Fixed by #3507
Closed

Joining document after it was renamed inside editor causes document conflict and potential data loss #3492

eszkadev opened this issue Feb 22, 2024 · 0 comments · Fixed by #3507
Assignees
@eszkadev

Comments

@eszkadev
Copy link
Contributor

Describe the bug
User can land in two instances of the same document when using rename inside Collabora Online.

To Reproduce
Steps to reproduce the behavior:

  1. Open document in Collabora Online
  2. Rename it inside editor using title bar input field
  3. Open new tab in the browser and open the same document second time from NC file picker
    Result: Tow sessions doesn't see each other, after saving conflict dialog appears

Expected behavior
Two users join the same session
@eszkadev eszkadev self-assigned this Feb 22, 2024
eszkadev added a commit to eszkadev/richdocuments that referenced this issue Feb 22, 2024
@eszkadev
Fixes nextcloud#3492 joining after document is renamed inside editor
4a5828b 
Bug:
1. Open document
2. Rename in Collabora Online using input in the title bar
3. In the new tab open the same document from file picker in NC
Result: 2 sessions are in different instances of the same document

getCallbackBaseUrl() puts "/" at the end, but WOPISrc was adding
additional one:
const wopiurl = getCallbackBaseUrl() + '/ ...

Then reconnected session after rename had single "/index.php"
but new session used "//index.php" what caused that COOL server
didn't consider both as the same identifier

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
juliushaertl added a commit that referenced this issue Feb 26, 2024
@juliushaertl
Merge pull request #3493 from eszkadev/private/eszkadev/fix-join-afte…
e40a0a0 
…r-rename

Fixes #3492 joining after document is renamed inside editor
backportbot bot pushed a commit that referenced this issue Feb 26, 2024
@eszkadev @backportbot
Fixes #3492 joining after document is renamed inside editor
517c801 
Bug:
1. Open document
2. Rename in Collabora Online using input in the title bar
3. In the new tab open the same document from file picker in NC
Result: 2 sessions are in different instances of the same document

getCallbackBaseUrl() puts "/" at the end, but WOPISrc was adding
additional one:
const wopiurl = getCallbackBaseUrl() + '/ ...

Then reconnected session after rename had single "/index.php"
but new session used "//index.php" what caused that COOL server
didn't consider both as the same identifier

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
@juliushaertl juliushaertl mentioned this issue Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eszkadev eszkadev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(release): Bump version to 8.3.2 nextcloud/richdocuments
1 participant
@eszkadev