Fixes #3492 joining after document is renamed inside editor #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebearon
reviewed
Feb 22, 2024
Bug: 1. Open document 2. Rename in Collabora Online using input in the title bar 3. In the new tab open the same document from file picker in NC Result: 2 sessions are in different instances of the same document getCallbackBaseUrl() puts "/" at the end, but WOPISrc was adding additional one: const wopiurl = getCallbackBaseUrl() + '/ ... Then reconnected session after rename had single "/index.php" but new session used "//index.php" what caused that COOL server didn't consider both as the same identifier Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
eszkadev
force-pushed
the
private/eszkadev/fix-join-after-rename
branch
from
4a5828b
to
eed26e3
Compare
juliushaertl
approved these changes
Feb 26, 2024
juliushaertl
added
bug
|
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
getCallbackBaseUrl() puts "/" at the end, but WOPISrc was adding additional one:
const wopiurl = getCallbackBaseUrl() + '/ ...
Then reconnected session after rename had single "/index.php" but new session used "//index.php" what caused that COOL server didn't consider both as the same identifier