Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot insert image from the NC storage into document #3902

Closed
eszkadev opened this issue Aug 14, 2024 · 1 comment
Closed

Cannot insert image from the NC storage into document #3902

eszkadev opened this issue Aug 14, 2024 · 1 comment
Labels
1. to develop Waiting for a developer bug Something isn't working high

Comments

@eszkadev
Copy link
Contributor

Describe the bug
User tries to insert remote image (from NC file picker) and it doesn't do anything.

To Reproduce
Steps to reproduce the behavior:

  1. Open any document in Nextcloud Office
  2. Insert -> Insert Image... (it shows NC file picker)
  3. Double click on any entry (or even anywhere in the dialog?)
  4. Click button 'Insert Image'

Result: no image inserted, in the browser console we can see error:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'path')
    at callback (FilesAppIntegration.js:141:1)
    at handleButtonClick (FilePicker-DUbP4INd.mjs:1590:1)
    at Object.callback (FilePicker-DUbP4INd.mjs:1584:1)
    at handleClick (NcDialogButton-JvyN3X6S.mjs:57:1)
    at $a (vue.runtime.esm.js:3033:30)
    at l.a (vue.runtime.esm.js:1832:20)
    at $a (vue.runtime.esm.js:3033:30)
    at Uw.e.$emit (vue.runtime.esm.js:3732:17)
    at click (NcButton.mjs:225:1)
    at $a (vue.runtime.esm.js:3033:30)
    ```

Note: the same error appears if double clicked empty dialog (no available images).

**Expected behavior**
Image is inserted.

## Server details
NC 30 (master), richdocuments (main)

richdocuments:
commit 5afc01eac15cb61378489234bd3adad81257b831 (HEAD -> main, origin/main)
Merge pull request #3835 from nextcloud/dependabot/npm_and_yarn/requirejs-2.3.7

Nextcloud git hash:
commit 003e4b9939e693f16fa24ed4beb2e0d8b0d37168 (HEAD -> master, origin/master, origin/HEAD)
Fix(l10n): Update translations from Transifex
    
@juliushaertl juliushaertl added bug Something isn't working 1. to develop Waiting for a developer high labels Aug 14, 2024
@juliushaertl
Copy link
Member

We should also extend the test to not only assert for the modal to be visible 🙈 https://github.com/nextcloud/richdocuments/blob/main/cypress/e2e/integration.spec.js#L115-L122

eszkadev added a commit to eszkadev/richdocuments that referenced this issue Aug 15, 2024
Steps to reproduce the behavior:

1. Open any document in Nextcloud Office
2. Insert -> Insert Image... (it shows NC file picker)
3. Double click on any entry (or even anywhere in the dialog?)
4. Click button 'Insert Image'

Result: no image inserted, in the browser console we can see error:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'path')

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
@elzody elzody closed this as completed in 57fc3b1 Aug 19, 2024
backportbot bot pushed a commit that referenced this issue Aug 19, 2024
Steps to reproduce the behavior:

1. Open any document in Nextcloud Office
2. Insert -> Insert Image... (it shows NC file picker)
3. Double click on any entry (or even anywhere in the dialog?)
4. Click button 'Insert Image'

Result: no image inserted, in the browser console we can see error:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'path')

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
backportbot bot pushed a commit that referenced this issue Aug 19, 2024
Steps to reproduce the behavior:

1. Open any document in Nextcloud Office
2. Insert -> Insert Image... (it shows NC file picker)
3. Double click on any entry (or even anywhere in the dialog?)
4. Click button 'Insert Image'

Result: no image inserted, in the browser console we can see error:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'path')

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
elzody added a commit that referenced this issue Aug 19, 2024
[stable29] Fixes #3902 : allow double click in image picker
elzody added a commit that referenced this issue Aug 19, 2024
[stable30] Fixes #3902 : allow double click in image picker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Waiting for a developer bug Something isn't working high
Projects
Archived in project
Development

No branches or pull requests

2 participants