Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] Fixes #3902 : allow double click in image picker #3927

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 19, 2024

Backport of PR #3914

Steps to reproduce the behavior:

1. Open any document in Nextcloud Office
2. Insert -> Insert Image... (it shows NC file picker)
3. Double click on any entry (or even anywhere in the dialog?)
4. Click button 'Insert Image'

Result: no image inserted, in the browser console we can see error:
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'path')

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
@backportbot backportbot bot requested review from elzody and eszkadev August 19, 2024 18:09
@backportbot backportbot bot added the 3. to review Ready to be reviewed label Aug 19, 2024
@backportbot backportbot bot added this to the Nextcloud 30 milestone Aug 19, 2024
@elzody elzody merged commit 959d21e into stable30 Aug 19, 2024
50 of 51 checks passed
@elzody elzody deleted the backport/3914/stable30 branch August 19, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants