Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve setup checks and url handling with separate callback url #3315

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Improve setup checks and url handling with separate callback url #3315

merged 5 commits into from
Dec 1, 2023

Commits on Nov 24, 2023

  1. fix: Properly handle internal urls 

    Improve handling of different URLs. From now on we will allow to
configure:

- wopi_url Used by Nextcloud to connect to Collabora in the backend
- wop_callback_url Passed to collabora to connect back to Nextcloud
  (optional, determined from the browser URL if not set)

The public_wopi_url which was only partly working is no longer ment to
be manually set and will be overwritten depending on the
/hosting/discovery response.

Further this PR improves:
- Add setup check on occ and admin page
- Give proper error on individual failures of the setup check
- Display configured and detected URLs to make setup issue debugging
  easier
- Refactor services to have a cleaner structure for setup checks,
  discovery and capabilities fetching

Signed-off-by: Julius Härtl <jus@bitgrid.net>
    @juliushaertl
    juliushaertl committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    ae8e248 View commit details
    Browse the repository at this point in the history

  2. chore: Update psalm baseline with missing symfony dependencies 

    Signed-off-by: Julius Härtl <jus@bitgrid.net>
    @juliushaertl
    juliushaertl committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    6db3aa5 View commit details
    Browse the repository at this point in the history

  3. feat: Add browser connectivity check 

    Signed-off-by: Julius Härtl <jus@bitgrid.net>
    @juliushaertl
    juliushaertl committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    7a97213 View commit details
    Browse the repository at this point in the history

  4. tests: Fix selectors on settings tests 

    Signed-off-by: Julius Härtl <jus@bitgrid.net>
    @juliushaertl
    juliushaertl committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    a9e8ee8 View commit details
    Browse the repository at this point in the history

  5. fix: Convert CSP idn domains to ascii (fix #3086) 

    Signed-off-by: Julius Härtl <jus@bitgrid.net>
    @juliushaertl
    juliushaertl committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    4aecf93 View commit details
    Browse the repository at this point in the history