-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve setup checks and url handling with separate callback url #3315
Conversation
1afbfcb
to
2ac99ec
Compare
@joshtrichards I'm unsure if you have a development setup, but I'd be curious about your feedback around this given that you did quite some issue triaging efforts. This PR aims to introduce one additional setting but the core part is to improve error reporting for admins. Maybe you have a way to give it a try? Or just give some feedback on further improving the error messages? |
7af4dd0
to
bb1ff0a
Compare
Improve handling of different URLs. From now on we will allow to configure: - wopi_url Used by Nextcloud to connect to Collabora in the backend - wop_callback_url Passed to collabora to connect back to Nextcloud (optional, determined from the browser URL if not set) The public_wopi_url which was only partly working is no longer ment to be manually set and will be overwritten depending on the /hosting/discovery response. Further this PR improves: - Add setup check on occ and admin page - Give proper error on individual failures of the setup check - Display configured and detected URLs to make setup issue debugging easier - Refactor services to have a cleaner structure for setup checks, discovery and capabilities fetching Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
78a2e31
to
4aecf93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/backport to stable28 |
Improve handling of different URLs. From now on we will allow to configure:
The public_wopi_url which was only partly working is no longer ment to be manually set and will be overwritten depending on the /hosting/discovery response.
Further this PR improves:
Note: One thing we cannot check as of right now is if the Collabora server is properly configured. This could be achieved continuing the implementation effort on CollaboraOnline/online#4353
Fix #3313
Fix #3262
Fix #1497
Fix #1835
occ command
Screenshots of new admin settings hints