-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use wopi callback url for all urls handed over to Collabora #3580
Conversation
@@ -38,7 +38,7 @@ const getCallbackBaseUrl = () => { | |||
} | |||
|
|||
const getWopiSrc = (fileId) => { | |||
// WOPISrc - URL that loolwsd will access (ie. pointing to ownCloud) | |||
// WOPISrc - URL that Collabora will use to access Nextcloud |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: URL generation can be put in an new short method, so the next time it needs just only one adjustment. Not a blocker.
40fad16
to
2f82662
Compare
Cypress failure seems related, will check |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2f82662
to
2cc2536
Compare
/backport to stable29 |
/backport to stable28 |
Fix #3579
Some URLs were not respecting the wopi_callback_url setting that we have in place now to configure the URL that Collabora will use to talk to Nextcloud, so this PR adapts those.