Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix: Allow configuring the wopi_callback_url #3575

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Apr 10, 2024

This is a minimal invasive backport of the parts of #3315 that allow configuring a separate callback URL for WOPI that can be used to use a different URL for requests Collabora is performing towards Nextcloud

occ config:app:set richdocuments wopi_callback_url --value="http://stable27"

@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Apr 10, 2024
Copy link

cypress bot commented Apr 10, 2024

Passing run #803 ↗︎

0 31 0 0 Flakiness 0

Details:

[stable27] fix: Allow configuring the wopi_callback_url
Project: Richdocuments Commit: c8814efb74
Status: Passed Duration: 02:57 💡
Started: Apr 10, 2024 3:33 PM Ended: Apr 10, 2024 3:36 PM

Review all test suite changes for PR #3575 ↗︎

@blizzz blizzz changed the title fix: Allow configuring the wopi_callback_url [stable27] fix: Allow configuring the wopi_callback_url Apr 10, 2024
}

const getWopiSrc = (fileId) => {
// WOPISrc - URL that loolwsd will access (ie. pointing to ownCloud)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃 for the sake of backport 🍸

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 Updated

Copy link
Member

@blizzz blizzz Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought it is kept intentionally to not have differences with higher branches

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit f3dd044 into stable27 Apr 11, 2024
45 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/internal-url-stable27 branch April 11, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants