Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] Use new property for admin user indication #3753

Merged
merged 1 commit into from
Jun 13, 2024
Merged

[stable27] Use new property for admin user indication #3753

merged 1 commit into from
Jun 13, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 12, 2024

Backport of PR #3748

@eszkadev @backportbot
Use new property for admin user indication
7c8bbc1 
is_admin field inside UserExtraInfo is deprecated now.
We use dedicated IsAdminUser property in CheckFileInfo instead.
Leave old code for now for backward compatibility.

see: CollaboraOnline/online#9242

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
@backportbot backportbot bot added the 3. to review Ready to be reviewed label Jun 12, 2024
@backportbot backportbot bot added this to the Nextcloud 27 milestone Jun 12, 2024
@cypress Cypress
Copy link

cypress bot commented Jun 12, 2024

4 failed tests on run #870 ↗︎

4 29 0 0 Flakiness 0

Details:

[stable27] Use new property for admin user indication
Project: Richdocuments Commit: 7c8bbc1a52
Status: Failed Duration: 03:21 💡
Started: Jun 12, 2024 7:02 AM Ended: Jun 12, 2024 7:05 AM
Failed  cypress/e2e/open.spec.js • 4 failed tests

View Output

Test Artifacts
Open existing office files > Classic UI: Open document.odt the viewer on file click Screenshots
Open existing office files > Classic UI: Open presentation.odp the viewer on file click Screenshots
Open existing office files > Classic UI: Open spreadsheet.ods the viewer on file click Screenshots
Open existing office files > Classic UI: Open drawing.odg the viewer on file click Screenshots

Review all test suite changes for PR #3753 ↗︎

@juliushaertl juliushaertl merged commit ed15c14 into stable27 Jun 13, 2024
38 of 40 checks passed
@juliushaertl juliushaertl deleted the backport/3748/stable27 branch June 13, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@eszkadev eszkadev Awaiting requested review from eszkadev

Assignees

@eszkadev eszkadev

Labels
3. to review Ready to be reviewed
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
2 participants
@juliushaertl @eszkadev