-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement PdfService using mikehaertl/php-pdftk #3806
Conversation
a0ca8b0
to
25a479a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments inline :)
ac56967
to
6f85ff4
Compare
dd31b09
to
88eb9d7
Compare
88eb9d7
to
25fcae6
Compare
@luka-nextcloud I pushed a few fixes while reviewing testing. Mainly to make the matching of fields work when fillling in to what is described below and to not overwrite the existing file @elzody I extended the OCS API also to be able to pass a destination along. However I noticed we have not really typed the fields array structure in the server API and here. Currently it seems to just use Sample curl commands
|
@juliushaertl The index should be the string index from the field class, afaik. The second curl command looks like it should have something like |
All right, the extra object with a content property originates from the Collabora API? |
25fcae6
to
0503fc5
Compare
@juliushaertl I think so, if I remember correctly you pass the fields to the endpoint in richdocuments as an array, and it loops over the fields passed and extracts the form control index and its matching properties (content, alias, etc.) then passes an object looking something like this to the Collabora API in JSON format: {
"ContentControls.ByIndex.0": {
"content": "Something"
},
"ContentControls.ByIndex.1": {
"alias": "Something else"
}
} And yeah because it allows changing multiple controls at a time the index is needed to specify what data each control should have via its index. Hopefully that makes sense, not sure if that's what you're asking |
38bc17a
to
daf510c
Compare
1180562
to
331450e
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
d5b15a0
to
58ceee1
Compare
…ce documents Signed-off-by: Julius Härtl <jus@bitgrid.net>
58ceee1
to
55cbed3
Compare
/backport to stable30 |
Summary
Follow-up