Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] feat: implement PdfService using mikehaertl/php-pdftk #3947

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 26, 2024

Backport of #3806

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

luka-nextcloud and others added 3 commits August 26, 2024 07:33
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…ce documents

Signed-off-by: Julius Härtl <jus@bitgrid.net>

[skip ci]
@backportbot backportbot bot added the 3. to review Ready to be reviewed label Aug 26, 2024
@backportbot backportbot bot added this to the Nextcloud 30 milestone Aug 26, 2024
@luka-nextcloud luka-nextcloud marked this pull request as ready for review August 26, 2024 10:10
@luka-nextcloud luka-nextcloud merged commit 672b187 into stable30 Aug 26, 2024
3 checks passed
@luka-nextcloud luka-nextcloud deleted the backport/3806/stable30 branch August 26, 2024 10:16
@juliushaertl
Copy link
Member

Those steps were missing:

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Follow up PR in #3949

@juliushaertl
Copy link
Member

Update branch protection rules since they were not checking for the right CI checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants