Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test runner: add 'testOnly' parameter to 'run' function #49733

Closed
koshic opened this issue Sep 20, 2023 · 0 comments · Fixed by #49743 or #49753
Closed

Test runner: add 'testOnly' parameter to 'run' function #49733

koshic opened this issue Sep 20, 2023 · 0 comments · Fixed by #49743 or #49753
Labels
feature request Issues that request new features to be added to Node.js. test_runner Issues and PRs related to the test runner subsystem.

Comments

@koshic
Copy link

koshic commented Sep 20, 2023

What is the problem this feature will solve?

As a developer, I want to be able use test runner programmatically via 'run' function and execute only tests marked with 'only' option. Currently it's possible only via CLI be adding '--test-only' parameter, or with dirty hack (see alternatives section).

What is the feature you are proposing to solve the problem?

Add 'testOnly' to 'run' parameters, similar to existing 'watch' or 'testNamePatterns'. It would be nice to have all test runner options available both on CLI and runtime API.

What alternatives have you considered?

Add '--test-only' to NODE_OPTIONS env variable before 'run' call. It works fine, but looks a bit ugly.
@koshic koshic added the feature request Issues that request new features to be added to Node.js. label Sep 20, 2023
@MoLow MoLow added the test_runner Issues and PRs related to the test runner subsystem. label Sep 20, 2023
@MoLow MoLow mentioned this issue Sep 21, 2023
Merged
@MoLow MoLow reopened this Sep 21, 2023
@MoLow MoLow mentioned this issue Sep 21, 2023
Merged
nodejs-github-bot pushed a commit that referenced this issue Sep 24, 2023
@MoLow
test_runner: accept testOnly in run
c9e72e3 
PR-URL: #49753
Fixes: #49733
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
ruyadorno pushed a commit that referenced this issue Sep 28, 2023
@MoLow @ruyadorno
test_runner: accept testOnly in run
80b342c 
PR-URL: #49753
Fixes: #49733
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
@MoLow @alexfernandez
test_runner: accept testOnly in run
f43f5a2 
PR-URL: nodejs#49753
Fixes: nodejs#49733
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
targos pushed a commit that referenced this issue Nov 27, 2023
@MoLow @targos
test_runner: accept testOnly in run
b283ae4 
PR-URL: #49753
Fixes: #49733
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
test_runner: accept testOnly in run
14374f4 
PR-URL: nodejs/node#49753
Fixes: nodejs/node#49733
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
@sercher
test_runner: accept testOnly in run
abb5133 
PR-URL: nodejs/node#49753
Fixes: nodejs/node#49733
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test_runner: accept testOnly in run MoLow/node
test_runner: accept only in run MoLow/node
2 participants
@MoLow @koshic