Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: accept testOnly in run #49743

Merged
merged 1 commit into from
Sep 21, 2023
Merged

test_runner: accept testOnly in run #49743

merged 1 commit into from
Sep 21, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Sep 21, 2023

Fixes: #49733

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 21, 2023
@MoLow
Copy link
Member Author

MoLow commented Sep 21, 2023

after this change --experimental-test-coverage is the last cli flag that cannot be passed to run (except for reporters - they should just use pipe), might be worth adding it as well. @cjihrig WDYT?

@atlowChemi
Copy link
Member

might be worth adding it as well

@MoLow I think it could be a nice addition, as it would simplify the usage (would not require understanding of streams etc) without adding a lot of overhead

atlowChemi
atlowChemi approved these changes Sep 21, 2023
View reviewed changes
doc/api/test.md Outdated Show resolved Hide resolved
test/fixtures/test-runner/test_only.js Outdated Show resolved Hide resolved
@MoLow
Copy link
Member Author

MoLow commented Sep 21, 2023

@MoLow I think it could be a nice addition, as it would simplify the usage (would not require understanding of streams etc) without adding a lot of overhead

I was not suggesting to add support for the reporter flags. was suggesting to add the coverage flag

@MoLow MoLow added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 21, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54117/

@cjihrig
Copy link
Contributor

cjihrig commented Sep 21, 2023

@cjihrig WDYT?

Sounds great to me.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54143/

@MoLow
test_runner: catch reporter errors
a4c7f81 
PR-URL: nodejs#49646
Fixes: nodejs#48937
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MoLow MoLow merged commit a4c7f81 into nodejs:main Sep 21, 2023
14 of 25 checks passed
@MoLow MoLow deleted the run-accept-only branch September 21, 2023 20:24
@MoLow MoLow mentioned this pull request Sep 21, 2023
Merged
This was referenced Sep 22, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@atlowChemi atlowChemi Awaiting requested review from atlowChemi

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test runner: add 'testOnly' parameter to 'run' function
5 participants
@MoLow @nodejs-github-bot @atlowChemi @cjihrig @benjamingr