Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test parallel/test-process-getactivehandles #5302

Closed
orangemocha opened this issue Feb 18, 2016 · 6 comments · Fixed by #5537
Closed

Investigate flaky test parallel/test-process-getactivehandles #5302

orangemocha opened this issue Feb 18, 2016 · 6 comments · Fixed by #5537
Assignees
@trevnorris
Labels
arm Issues and PRs related to the ARM platform. test Issues and PRs related to the tests.

Comments

@orangemocha
Copy link
Contributor

Flaky on ARM on current master:

https://ci.nodejs.org/job/node-stress-single-test/504/nodes=pi2-raspbian-wheezy/console

not ok 1 test-process-getactivehandles.js
# TIMEOUT
  ---
  duration_ms: 120.54

cc @nodejs/testing
@orangemocha orangemocha added the arm Issues and PRs related to the ARM platform. label Feb 18, 2016
orangemocha added a commit to orangemocha/io.js that referenced this issue Feb 18, 2016
@orangemocha
test: test-process-getactivehandles is flaky
711ac5d 
Ref: nodejs#5302
@orangemocha orangemocha mentioned this issue Feb 18, 2016
Closed
@Trott Trott added the test Issues and PRs related to the tests. label Feb 18, 2016
@Trott
Copy link
Member

Trott commented Feb 18, 2016

/cc @trevnorris

orangemocha added a commit that referenced this issue Feb 19, 2016
@orangemocha
test: test-process-getactivehandles is flaky
c05a330 
Ref: #5302

PR-URL: #5303
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg pushed a commit that referenced this issue Feb 21, 2016
@orangemocha @rvagg
test: test-process-getactivehandles is flaky
d9177e7 
Ref: #5302

PR-URL: #5303
Reviewed-By: Rich Trott <rtrott@gmail.com>
@trevnorris trevnorris self-assigned this Feb 25, 2016
@trevnorris
Copy link
Contributor

More pi2 fun.

@trevnorris
Copy link
Contributor

how often is this flakey? I've been trying it out on a pi2 machine and hasn't failed for me.

@orangemocha
Copy link
Contributor Author

In the CI run (https://ci.nodejs.org/job/node-stress-single-test/504/nodes=pi2-raspbian-wheezy/console) it failed 2 times out of 100. We can start a longer run if you need more data.

@trevnorris
Copy link
Contributor

May have a fix for this. Will PR it soon.

@trevnorris trevnorris mentioned this issue Mar 2, 2016
Merged
4 tasks
@trevnorris
Copy link
Contributor

Linked a fix for the test.

trevnorris added a commit to trevnorris/node that referenced this issue Mar 3, 2016
@trevnorris
test: prevent flakey test on pi2
5d7265f 
Looping rapidly and making new connections causes problems on pi2.
Instead create a new connection when an old connection has already been
made. Running a stress test of 600 times and they all passed.

Fixes: nodejs#5302
PR-URL: nodejs#5537
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Fishrock123 pushed a commit that referenced this issue Mar 8, 2016
@trevnorris @Fishrock123
test: prevent flakey test on pi2
9dfb897 
Looping rapidly and making new connections causes problems on pi2.
Instead create a new connection when an old connection has already been
made. Running a stress test of 600 times and they all passed.

Fixes: #5302
PR-URL: #5537
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Fishrock123 pushed a commit that referenced this issue Mar 8, 2016
@trevnorris @Fishrock123
test: prevent flakey test on pi2
e6210d5 
Looping rapidly and making new connections causes problems on pi2.
Instead create a new connection when an old connection has already been
made. Running a stress test of 600 times and they all passed.

Fixes: #5302
PR-URL: #5537
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
MylesBorins pushed a commit that referenced this issue Mar 17, 2016
@trevnorris
test: prevent flakey test on pi2
a1747c9 
Looping rapidly and making new connections causes problems on pi2.
Instead create a new connection when an old connection has already been
made. Running a stress test of 600 times and they all passed.

Fixes: #5302
PR-URL: #5537
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
@trevnorris
test: prevent flakey test on pi2
85f927a 
Looping rapidly and making new connections causes problems on pi2.
Instead create a new connection when an old connection has already been
made. Running a stress test of 600 times and they all passed.

Fixes: #5302
PR-URL: #5537
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevnorris trevnorris

Labels
arm Issues and PRs related to the ARM platform. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: prevent flakey test on pi2 trevnorris/node
3 participants
@trevnorris @Trott @orangemocha