test: prevent flakey test on pi2 #5537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Thank you. Could also remove the line in test/parallel/parallel.status that marks this test as flaky? |
|
CI stress run in progress: https://ci.nodejs.org/job/node-stress-single-test/552/ |
|
Test change LGTM if CI is green. What @orangemocha said about removing the line in |
mscdex
added
test
|
Stress run is green! LGTM |
|
The regular CI run failed because it wasn't certified safe (sigh). Here's a new run: https://ci.nodejs.org/job/node-test-pull-request/1827/ |
|
CI is green. |
Looping rapidly and making new connections causes problems on pi2. Instead create a new connection when an old connection has already been made. Running a stress test of 600 times and they all passed. Fixes: nodejs#5302 PR-URL: nodejs#5537 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
|
Thanks. Landed in 5d7265f. |
Merged
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
Looping rapidly and making new connections causes problems on pi2. Instead create a new connection when an old connection has already been made. Running a stress test of 600 times and they all passed. Fixes: #5302 PR-URL: #5537 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Fishrock123
pushed a commit
that referenced
this pull request
Mar 8, 2016
Looping rapidly and making new connections causes problems on pi2. Instead create a new connection when an old connection has already been made. Running a stress test of 600 times and they all passed. Fixes: #5302 PR-URL: #5537 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Looping rapidly and making new connections causes problems on pi2. Instead create a new connection when an old connection has already been made. Running a stress test of 600 times and they all passed. Fixes: #5302 PR-URL: #5537 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Looping rapidly and making new connections causes problems on pi2. Instead create a new connection when an old connection has already been made. Running a stress test of 600 times and they all passed. Fixes: #5302 PR-URL: #5537 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Description of change
Looping rapidly and making new connections causes problems on pi2.
Instead create a new connection when an old connection has already been
made. Running a stress test of 600 times and they all passed.
Fixes: #5302
R= @orangemocha
R= @Trott
CI: https://ci.nodejs.org/job/node-test-pull-request/1824/