Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9.x backport] http2: fixes error handling #19478

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions lib/internal/http2/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -2041,19 +2041,12 @@ function afterOpen(session, options, headers, streamOptions, err, fd) {
headers, streamOptions));
}

function streamOnError(err) {
// we swallow the error for parity with HTTP1
// all the errors that ends here are not critical for the project
}


class ServerHttp2Stream extends Http2Stream {
constructor(session, handle, id, options, headers) {
super(session, options);
this[kInit](id, handle);
this[kProtocol] = headers[HTTP2_HEADER_SCHEME];
this[kAuthority] = headers[HTTP2_HEADER_AUTHORITY];
this.on('error', streamOnError);
}

// true if the remote peer accepts push streams
Expand Down
7 changes: 7 additions & 0 deletions test/parallel/test-http2-misbehaving-multiplex.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,14 @@ const server = h2.createServer();
server.on('stream', common.mustCall((stream) => {
stream.respond();
stream.end('ok');

// the error will be emitted asynchronously
stream.on('error', common.expectsError({
code: 'ERR_HTTP2_ERROR',
message: 'Stream was already closed or invalid'
}));
}, 2));

server.on('session', common.mustCall((session) => {
session.on('error', common.expectsError({
code: 'ERR_HTTP2_ERROR',
Expand Down
8 changes: 6 additions & 2 deletions test/parallel/test-http2-server-errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,16 @@ const h2 = require('http2');

const server = h2.createServer();

process.on('uncaughtException', common.mustCall(function(err) {
assert.strictEqual(err.message, 'kaboom no handler');
}));

server.on('stream', common.mustCall(function(stream) {
// there is no 'error' handler, and this will not crash
// there is no 'error' handler, and this will crash
stream.write('hello');
stream.resume();

expected = new Error('kaboom');
expected = new Error('kaboom no handler');
stream.destroy(expected);
server.close();
}));
Expand Down
6 changes: 6 additions & 0 deletions test/parallel/test-http2-server-push-stream-head.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ server.on('stream', common.mustCall((stream, headers) => {
}, common.mustCall((err, push, headers) => {
assert.strictEqual(push._writableState.ended, true);
push.respond();
// cannot write to push() anymore
push.on('error', common.expectsError({
type: Error,
code: 'ERR_STREAM_WRITE_AFTER_END',
message: 'write after end'
}));
assert(!push.write('test'));
stream.end('test');
}));
Expand Down
14 changes: 11 additions & 3 deletions test/parallel/test-http2-server-rst-stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,22 @@ const {
const tests = [
[NGHTTP2_NO_ERROR, false],
[NGHTTP2_NO_ERROR, false],
[NGHTTP2_PROTOCOL_ERROR, true],
[NGHTTP2_PROTOCOL_ERROR, true, 1],
[NGHTTP2_CANCEL, false],
[NGHTTP2_REFUSED_STREAM, true],
[NGHTTP2_INTERNAL_ERROR, true]
[NGHTTP2_REFUSED_STREAM, true, 7],
[NGHTTP2_INTERNAL_ERROR, true, 2]
];

const server = http2.createServer();
server.on('stream', (stream, headers) => {
const test = tests.find((t) => t[0] === Number(headers.rstcode));
if (test[1]) {
stream.on('error', common.expectsError({
type: Error,
code: 'ERR_HTTP2_STREAM_ERROR',
message: `Stream closed with error code ${test[2]}`
}));
}
stream.close(headers.rstcode | 0);
});

Expand Down
5 changes: 5 additions & 0 deletions test/parallel/test-http2-server-stream-session-destroy.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ server.on('stream', common.mustCall((stream) => {
type: Error
}
);
stream.on('error', common.expectsError({
type: Error,
code: 'ERR_STREAM_WRITE_AFTER_END',
message: 'write after end'
}));
assert.strictEqual(stream.write('data'), false);
}));

Expand Down