Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: don't emit 'end' after 'error' #31182

Closed
wants to merge 6 commits into from
Closed

stream: don't emit 'end' after 'error' #31182

wants to merge 6 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jan 3, 2020 •
edited
Loading

Don't emit 'end' after 'error'. There was still a case where this could occur (see test).

Note, that some tests that assume 'end' after 'error' needed to be modified.

Refs: #6083

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Jan 3, 2020
@ronag
Copy link
Member Author

ronag commented Jan 3, 2020 •
edited
Loading

semver-major

@Trott Trott added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 3, 2020
@BridgeAR
Copy link
Member

BridgeAR commented Jan 4, 2020

@nodejs/streams PTAL

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28189/

@ronag ronag force-pushed the readable-end-error branch 3 times, most recently from 826b5d4 to dfc361e Compare January 4, 2020 10:44
@ronag ronag requested a review from lpinca January 5, 2020 12:01
mcollina
mcollina approved these changes Jan 5, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 6, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28226/

@Trott
Copy link
Member

Trott commented Jan 6, 2020

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2188/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28228/

@Trott
Copy link
Member

Trott commented Jan 6, 2020

CITGM looks good.

@Trott
Copy link
Member

Trott commented Jan 6, 2020

Landed in 66f4e4e

@Trott Trott closed this Jan 6, 2020
Trott pushed a commit that referenced this pull request Jan 6, 2020
@ronag @Trott
stream: do not emit 'end' after 'error'
66f4e4e 
Refs: #6083

PR-URL: #31182
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Mar 10, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ronag @BridgeAR @nodejs-github-bot @Trott @mcollina @lpinca