Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: reformatted, fixed bugs #2504

Merged
merged 1 commit into from
Jul 17, 2024
Merged

python: reformatted, fixed bugs #2504

merged 1 commit into from
Jul 17, 2024

Conversation

pasabanov
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

#1447 #1449 #1984 #1986 #2113

Describe changes:

Reformatted Python scripts to match PEP.

Fixed mistake in class path: urllib.error.HTTPError.
The error module wasn't imported from urllib.

This problem has two solutions:

  1. import urllib.error
  2. Use urllib.request.HTTPError as HTTPError is importted from urllib.error in request.py.

I chose the second option as it is simpler.

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@IvanNardi IvanNardi merged commit 0a3a826 into ntop:dev Jul 17, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants