Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipaddr2list.py, ndpi2timeline.py: reformatted #2509

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

pasabanov
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

#2504

I forgot to include my ipaddr2list.py changes into the previous PR #2504 XD
I also found that file ndpi2fimeline.py can be reformatted as well.

Describe changes:

Reformatted Python scripts to match PEP.

Also:

  1. Changed dict() to {} for performance reasons.
  2. Removed id variable as it is unused (and it also shadows the built-in name 'id').
  3. Commented out the if(0): code as it is unreachable.

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IvanNardi
Copy link
Collaborator

Thanks for all these improvements!

@IvanNardi IvanNardi merged commit be0b2c2 into ntop:dev Jul 18, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants