Added support for retrieving client secret from okta_app_oauth data source #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickardp
force-pushed
the
data-client-secret
branch
2 times, most recently
from
9604d37
to
d891aae
Compare
rickardp
force-pushed
the
data-client-secret
branch
from
d891aae
to
541dd43
Compare
dkulchinsky
reviewed
Sep 6, 2022
| @@ -195,6 +202,35 @@ func dataSourceAppOauthRead(ctx context.Context, d *schema.ResourceData, m inter | |||
| if err != nil { | |||
| return diag.Errorf("failed to list OAuth's app groups and users: %v", err) | |||
| } | |||
| skipClientSecrets := false // Do we ever need to skip doing this? | |||
There was a problem hiding this comment.
there's an omit_secret attribute in the resource, we could follow the same pattern here?
terraform-provider-okta/okta/resource_okta_app_oauth.go
Lines 146 to 152 in 090c474
terraform-provider-okta/okta/resource_okta_app_oauth.go
Lines 532 to 534 in 090c474
|
@dkulchinsky I'll try to address this in a release this week. Last week my focus was pulled away on to another Okta project. |
|
@rickardp @dkulchinsky I'll do a separate PR and bring in this behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem for the specific case reported in #1279.
This works in the case that I have tested, but I am not sure if it is a good idea to fetch the secrets using this call (maybe it causes problems with token scopes) in which case maybe there is a need to opt in/out of this.
Draft PR because it currently serves as discussion material and I do not expect it to be merged in the current state. I can spend some time fixing it up based on review feedback if this is the correct path for solving this issue.