Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add client_secret attribute on data source okta_app_oauth #1307

Merged
merged 6 commits into from
Sep 14, 2022
Merged

Add client_secret attribute on data source okta_app_oauth #1307

merged 6 commits into from
Sep 14, 2022

Conversation

monde
Copy link
Collaborator

@monde monde commented Sep 14, 2022

Adds latest active client secret value for data source okta_app_oauth.
Expands and refactors work from

Tests pass on OIE and Classic

$ TF_ACC=1 go test -tags unit -mod=readonly -test.v -run ^TestAccOktaDataSourceAppOauth_read$ ./okta 2>&1
=== RUN   TestAccOktaDataSourceAppOauth_read
--- PASS: TestAccOktaDataSourceAppOauth_read (15.49s)
PASS
ok      github.com/okta/terraform-provider-okta/okta    15.723s

@monde monde merged commit c1e7cbc into master Sep 14, 2022
@dkulchinsky
Copy link
Contributor

Thanks @monde, this is amazing 👍🏼

@monde monde deleted the rickardp_data-client-secret branch September 26, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijetmahabaleshwar-okta vijetmahabaleshwar-okta vijetmahabaleshwar-okta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@monde @dkulchinsky @vijetmahabaleshwar-okta @rickardp